From 2730d2e14f650a2baed19fe650bdabaa1a0b5101 Mon Sep 17 00:00:00 2001 From: tamasmeszaros Date: Mon, 24 Jul 2023 10:54:22 +0200 Subject: [PATCH] Remove unneeded check from fill bed test --- src/libslic3r/Arrange/Scene.hpp | 2 +- tests/arrange/test_arrange_integration.cpp | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/libslic3r/Arrange/Scene.hpp b/src/libslic3r/Arrange/Scene.hpp index c5626bb9ac..f917ed3c2f 100644 --- a/src/libslic3r/Arrange/Scene.hpp +++ b/src/libslic3r/Arrange/Scene.hpp @@ -18,7 +18,7 @@ namespace Slic3r { namespace arr2 { // An interface that allows to store arbitrary data (std::any) under a specific // key in an object implementing the interface. This is later used to pass -// arbitrary parameters from any arranged object down to the arrangement core. +// arbitrary parameters from any arrangeable object down to the arrangement core. class AnyWritable { public: diff --git a/tests/arrange/test_arrange_integration.cpp b/tests/arrange/test_arrange_integration.cpp index a7c9275600..26ff19c329 100644 --- a/tests/arrange/test_arrange_integration.cpp +++ b/tests/arrange/test_arrange_integration.cpp @@ -659,10 +659,12 @@ TEMPLATE_TEST_CASE("Bed needs to be completely filled with 1cm cubes", REQUIRE(task->unselected.empty()); REQUIRE(result->to_add.size() + result->arranged_items.size() == arr2::model_instance_count(m)); - REQUIRE( - std::all_of(task->selected.begin(), task->selected.end(), [](auto &itm) { - return arr2::get_bed_index(itm) == 0; - })); + // All the existing items should be on the physical bed + REQUIRE(std::all_of(result->arranged_items.begin(), + result->arranged_items.end(), [](auto &itm) { + return arr2::get_bed_index(itm) == 0; + })); + REQUIRE( std::all_of(result->to_add.begin(), result->to_add.end(), [](auto &itm) { return arr2::get_bed_index(itm) == 0;