From 34139a5d9d83b306ec7ee67775f53b9c8f266661 Mon Sep 17 00:00:00 2001 From: Filip Sykala Date: Wed, 23 Feb 2022 11:20:59 +0100 Subject: [PATCH] Fix warning ../src/libslic3r/ShapeDiameterFunction.cpp:134:29: warning: unused variable 'granularity' [-Wunused-variable] ../src/libslic3r/ShapeDiameterFunction.cpp:408:67: warning: suggest parentheses around comparison in operand of '==' [-Wparentheses] ../src/libslic3r/ShapeDiameterFunction.cpp:446:30: warning: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Wsign-compare] --- src/libslic3r/ShapeDiameterFunction.cpp | 2 +- src/libslic3r/SimplifyMeshImpl.hpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libslic3r/ShapeDiameterFunction.cpp b/src/libslic3r/ShapeDiameterFunction.cpp index 71eacf5722..2625f1d583 100644 --- a/src/libslic3r/ShapeDiameterFunction.cpp +++ b/src/libslic3r/ShapeDiameterFunction.cpp @@ -405,7 +405,7 @@ indexed_triangle_set ShapeDiameterFunction::subdivide( int index_offset = count_edge_vertices/2; size_t i2 = (divide_index + 2) % 3; - if (count_edge_vertices % 2 == 0 && key_swap == l[i1] < l[i2]) { + if ((count_edge_vertices % 2 == 0) && (key_swap == (l[i1] < l[i2]))) { --index_offset; } int sign = (vs.positive_order) ? 1 : -1; diff --git a/src/libslic3r/SimplifyMeshImpl.hpp b/src/libslic3r/SimplifyMeshImpl.hpp index 60648168c5..525b2ed78e 100644 --- a/src/libslic3r/SimplifyMeshImpl.hpp +++ b/src/libslic3r/SimplifyMeshImpl.hpp @@ -809,7 +809,6 @@ void SimplifiableMesh::remove_small_edges(double edge_length, double max_t // main iteration loop int deleted_triangles = 0; std::vector deleted0, deleted1; - size_t triangle_count = m_faceinfo.size(); // main reduction become on first iteration for (int iteration = 0; iteration < 99; iteration++) {