From 8295f81685f1c937af5bd4978da1e3dd5687b6db Mon Sep 17 00:00:00 2001 From: tamasmeszaros Date: Fri, 19 Mar 2021 13:39:54 +0100 Subject: [PATCH 1/2] Fix mac warnings --- src/libslic3r/MeshBoolean.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libslic3r/MeshBoolean.cpp b/src/libslic3r/MeshBoolean.cpp index da5c956385..8a03310fe9 100644 --- a/src/libslic3r/MeshBoolean.cpp +++ b/src/libslic3r/MeshBoolean.cpp @@ -155,7 +155,7 @@ template TriangleMesh cgal_to_triangle_mesh(const _Mesh &cgalmesh) int i = 0; Vec3i facet; - for (const auto &v : vtc) { + for (auto v : vtc) { if (i > 2) { i = 0; break; } facet(i++) = v; } From aa2d8915ef9702eb3c1f33bb958cf19412ee9445 Mon Sep 17 00:00:00 2001 From: tamasmeszaros Date: Fri, 19 Mar 2021 14:02:20 +0100 Subject: [PATCH 2/2] Fix crash caused by boost log trivial on mac --- src/libslic3r/MeshBoolean.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/libslic3r/MeshBoolean.cpp b/src/libslic3r/MeshBoolean.cpp index 8a03310fe9..25ee3e4af8 100644 --- a/src/libslic3r/MeshBoolean.cpp +++ b/src/libslic3r/MeshBoolean.cpp @@ -1,7 +1,6 @@ #include "Exception.hpp" #include "MeshBoolean.hpp" #include "libslic3r/TriangleMesh.hpp" -#include "boost/log/trivial.hpp" #undef PI // Include igl first. It defines "L" macro which then clashes with our localization @@ -160,11 +159,8 @@ template TriangleMesh cgal_to_triangle_mesh(const _Mesh &cgalmesh) facet(i++) = v; } - if (i == 3) { + if (i == 3) facets.emplace_back(facet); - } else { - BOOST_LOG_TRIVIAL(error) << "CGAL face is not a triangle."; - } } TriangleMesh out{points, facets};