GitHub-Proxy/PrusaSlicer
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/prusa3d/PrusaSlicer.git synced 2025-08-18 02:35:55 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

replace abs with comparison in the QEC, it is faster

Browse Source
This commit is contained in:
PavelMikus 2022-05-11 11:12:20 +02:00
parent faaaf4148e
commit 49e6762ae7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libslic3r/QuadricEdgeCollapse.cpp
View File

@ -614,15 +614,15 @@ bool QuadricEdgeCollapse::is_flipped(const Vec3f & new_vertex,
d2.normalize(); d2.normalize();
float dot = d1.dot(d2); float dot = d1.dot(d2);
if (std::abs(dot) > triangle_beauty_threshold) { // OK, the new triangle is suspiciously ugly, but it can still be better than the original if (dot > triangle_beauty_threshold || dot < -triangle_beauty_threshold) { // OK, the new triangle is suspiciously ugly, but it can still be better than the original
const Vec3f &v_orig = its.vertices[t[(e_info.edge) % 3]]; const Vec3f &v_orig = its.vertices[t[(e_info.edge) % 3]];
Vec3f d1_orig = vf - v_orig; Vec3f d1_orig = vf - v_orig;
d1_orig.normalize(); d1_orig.normalize();
Vec3f d2_orig = vs - v_orig; Vec3f d2_orig = vs - v_orig;
d2_orig.normalize(); d2_orig.normalize();
if (std::abs(d1_orig.dot(d2_orig)) < std::abs(dot)) { // original was not that ugly, so return flipped if (std::fabs(d1_orig.dot(d2_orig)) < std::fabs(dot)) { // original was not that ugly, so return flipped
return true; return true;
} } // else original triangle was worse than the new, so don't discard the new yet
} }
// IMPROVE: propagate new normal // IMPROVE: propagate new normal
Vec3f n = d1.cross(d2); Vec3f n = d1.cross(d2);