From 8de949562a9990b16fe692fc3b1eea2513e6f1ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20=C5=A0ach?= Date: Mon, 24 Feb 2025 11:23:37 +0100 Subject: [PATCH] SPE-2700 Scarf seam minor fixes - Do not generate scarf seam on the first layer - Fix links to the web manual pages --- src/libslic3r/GCode/SeamPlacer.cpp | 4 ++++ src/slic3r/GUI/Tab.cpp | 15 ++++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/libslic3r/GCode/SeamPlacer.cpp b/src/libslic3r/GCode/SeamPlacer.cpp index 36d7b119b4..ab89399901 100644 --- a/src/libslic3r/GCode/SeamPlacer.cpp +++ b/src/libslic3r/GCode/SeamPlacer.cpp @@ -339,6 +339,10 @@ boost::variant finalize_seam_position( perimeter.angle_types[seam_choice.previous_index] == Perimeters::AngleType::smooth }; + if (perimeter.layer_index == 0) { + place_scarf_seam = false; + } + if (region->config().scarf_seam_only_on_smooth && !is_smooth) { place_scarf_seam = false; } diff --git a/src/slic3r/GUI/Tab.cpp b/src/slic3r/GUI/Tab.cpp index 5a95888607..64a43294a1 100644 --- a/src/slic3r/GUI/Tab.cpp +++ b/src/slic3r/GUI/Tab.cpp @@ -1468,13 +1468,14 @@ void TabPrint::build() optgroup->append_single_option_line("seam_gap_distance", category_path + "seam-gap-distance"); optgroup->append_single_option_line("staggered_inner_seams", category_path + "staggered-inner-seams"); - optgroup->append_single_option_line("scarf_seam_placement", category_path + "scarf-seam-placement"); - optgroup->append_single_option_line("scarf_seam_only_on_smooth", category_path + "scarf-seam-only-on-smooth"); - optgroup->append_single_option_line("scarf_seam_start_height", category_path + "scarf-seam-start-height"); - optgroup->append_single_option_line("scarf_seam_entire_loop", category_path + "scarf-seam-entire-loop"); - optgroup->append_single_option_line("scarf_seam_length", category_path + "scarf-seam-length"); - optgroup->append_single_option_line("scarf_seam_max_segment_length", category_path + "scarf-seam-max-segment-length"); - optgroup->append_single_option_line("scarf_seam_on_inner_perimeters", category_path + "scarf-seam-on-inner-perimeters"); + const std::string scarf_seam_path{"seam-position_151069#"}; + optgroup->append_single_option_line("scarf_seam_placement", scarf_seam_path + "scarf-joint-placement"); + optgroup->append_single_option_line("scarf_seam_only_on_smooth", scarf_seam_path + "scarf-joint-only-on-smooth-perimeters"); + optgroup->append_single_option_line("scarf_seam_start_height", scarf_seam_path + "scarf-start-height"); + optgroup->append_single_option_line("scarf_seam_entire_loop", scarf_seam_path + "scarf-joint-around-entire-perimeter"); + optgroup->append_single_option_line("scarf_seam_length", scarf_seam_path + "scarf-joint-length"); + optgroup->append_single_option_line("scarf_seam_max_segment_length", scarf_seam_path + "max-scarf-joint-segment-length"); + optgroup->append_single_option_line("scarf_seam_on_inner_perimeters", scarf_seam_path + "scarf-joint-on-inner-perimeters"); optgroup->append_single_option_line("external_perimeters_first", category_path + "external-perimeters-first"); optgroup->append_single_option_line("gap_fill_enabled", category_path + "fill-gaps");