From 9225f237b2b902b7bfc152c094906aebf95ada72 Mon Sep 17 00:00:00 2001 From: Filip Sykala - NTB T15p Date: Thu, 15 Sep 2022 17:03:39 +0200 Subject: [PATCH] Fix issue 40 --- src/slic3r/GUI/Jobs/EmbossJob.cpp | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/slic3r/GUI/Jobs/EmbossJob.cpp b/src/slic3r/GUI/Jobs/EmbossJob.cpp index 9f77f2fdee..6c3d42edff 100644 --- a/src/slic3r/GUI/Jobs/EmbossJob.cpp +++ b/src/slic3r/GUI/Jobs/EmbossJob.cpp @@ -13,7 +13,6 @@ #include "slic3r/GUI/MainFrame.hpp" #include "slic3r/GUI/GUI.hpp" #include "slic3r/GUI/GUI_App.hpp" -#include "slic3r/GUI/GUI_ObjectManipulation.hpp" #include "slic3r/GUI/Gizmos/GLGizmoEmboss.hpp" #include "slic3r/GUI/CameraUtils.hpp" #include "slic3r/GUI/format.hpp" @@ -191,11 +190,6 @@ void EmbossCreateVolumeJob::finalize(bool canceled, std::exception_ptr &eptr) { obj_list->selection_changed(); - // WHY selection_changed set manipulation to world ??? - // so I set it back to local --> RotationGizmo need it - ObjectManipulation *manipul = wxGetApp().obj_manipul(); - manipul->set_coordinates_type(ECoordinatesType::Local); - // redraw scene canvas->reload_scene(true); } @@ -613,17 +607,21 @@ void priv::update_volume(TriangleMesh &&mesh, volume->set_new_unique_id(); volume->calculate_convex_hull(); volume->get_object()->invalidate_bounding_box(); - volume->name = data.volume_name; volume->text_configuration = data.text_configuration; - // update volume in right panel( volume / object name) const Selection &selection = canvas->get_selection(); const GLVolume * gl_volume = selection.get_volume( *selection.get_volume_idxs().begin()); int object_idx = gl_volume->object_idx(); - int volume_idx = gl_volume->volume_idx(); - ObjectList *obj_list = app.obj_list(); - obj_list->update_name_in_list(object_idx, volume_idx); + + if (volume->name != data.volume_name) { + volume->name = data.volume_name; + + // update volume name in right panel( volume / object name) + int volume_idx = gl_volume->volume_idx(); + ObjectList *obj_list = app.obj_list(); + obj_list->update_name_in_list(object_idx, volume_idx); + } // update printable state on canvas if (volume->type() == ModelVolumeType::MODEL_PART)