GitHub-Proxy/PrusaSlicer
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/prusa3d/PrusaSlicer.git synced 2025-07-03 13:15:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

AppConfig: Prevent race conditions when writing slic3r.ini

Browse Source
This commit is contained in:
Vojtech Kral 2018-10-05 16:05:53 +02:00 committed by bubnikv
parent 55b43077d7
commit c06cf009eb
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
xs/src/slic3r/GUI/AppConfig.cpp
View File

@ -16,6 +16,8 @@
#include <boost/property_tree/ini_parser.hpp> #include <boost/property_tree/ini_parser.hpp>
#include <boost/property_tree/ptree.hpp> #include <boost/property_tree/ptree.hpp>
#include <boost/algorithm/string/predicate.hpp> #include <boost/algorithm/string/predicate.hpp>
#include <boost/format.hpp>
namespace Slic3r { namespace Slic3r {
@ -125,8 +127,14 @@ void AppConfig::load()
void AppConfig::save() void AppConfig::save()
{ {
// The config is first written to a file with a PID suffix and then moved
// to avoid race conditions with multiple instances of Slic3r
const auto path = config_path();
std::string path_pid = (boost::format("%1%.%2%") % path % get_current_pid()).str();
boost::nowide::ofstream c; boost::nowide::ofstream c;
c.open(AppConfig::config_path(), std::ios::out | std::ios::trunc); c.open(path_pid, std::ios::out | std::ios::trunc);
c << "# " << Slic3r::header_slic3r_generated() << std::endl; c << "# " << Slic3r::header_slic3r_generated() << std::endl;
// Make sure the "no" category is written first. // Make sure the "no" category is written first.
for (const std::pair<std::string, std::string> &kvp : m_storage[""]) for (const std::pair<std::string, std::string> &kvp : m_storage[""])
@ -155,6 +163,9 @@ void AppConfig::save()
} }
} }
c.close(); c.close();
rename_file(path_pid, path);
m_dirty = false; m_dirty = false;
} }