From c9605580ee684d6f6c40e74566fe3a952a56ebbc Mon Sep 17 00:00:00 2001 From: Thomas Rahm <67757218+ThomasRahm@users.noreply.github.com> Date: Thu, 2 Feb 2023 23:19:03 +0100 Subject: [PATCH] Fix issue causing some tips to not generate, as remaining_overhang was nearly always empty Fixes https://github.com/prusa3d/PrusaSlicer/issues/9459 --- src/libslic3r/TreeSupport.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libslic3r/TreeSupport.cpp b/src/libslic3r/TreeSupport.cpp index c48ef230b5..19e4c7d899 100644 --- a/src/libslic3r/TreeSupport.cpp +++ b/src/libslic3r/TreeSupport.cpp @@ -1055,9 +1055,8 @@ static void generate_initial_areas( Polygons overhang_regular; { const Polygons &overhang_raw = overhangs[layer_idx + z_distance_delta]; - overhang_regular = mesh_group_settings.support_offset == 0 ? - overhang_raw : - safe_offset_inc(overhang_raw, mesh_group_settings.support_offset, relevant_forbidden, mesh_config.min_radius * 1.75 + mesh_config.xy_min_distance, 0, 1); + // When support_offset = 0 safe_offset_inc will only be the difference between overhang_raw and relevant_forbidden, that has to be calculated anyway. + overhang_regular = safe_offset_inc(overhang_raw, mesh_group_settings.support_offset, relevant_forbidden, mesh_config.min_radius * 1.75 + mesh_config.xy_min_distance, 0, 1); //check_self_intersections(overhang_regular, "overhang_regular1"); // offset ensures that areas that could be supported by a part of a support line, are not considered unsupported overhang