GitHub-Proxy/PrusaSlicer
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/prusa3d/PrusaSlicer.git synced 2025-08-16 22:15:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

SPE-2701: Disable scarf seam on thick bridges (#14190)

Browse Source
This commit is contained in:
Martin Šach 2025-02-24 15:50:39 +01:00 committed by Lukas Matena
parent 8de949562a
commit e84f400fad
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/libslic3r/GCode/SeamPlacer.cpp
View File

@ -271,7 +271,8 @@ boost::variant<Point, Scarf::Scarf> finalize_seam_position(
SeamChoice seam_choice, SeamChoice seam_choice,
const Perimeters::Perimeter &perimeter, const Perimeters::Perimeter &perimeter,
const bool staggered_inner_seams, const bool staggered_inner_seams,
const bool flipped const bool flipped,
const bool thick_bridges
) { ) {
using Perimeters::offset_along_perimeter; using Perimeters::offset_along_perimeter;
using Perimeters::PointOnPerimeter; using Perimeters::PointOnPerimeter;
@ -351,6 +352,15 @@ boost::variant<Point, Scarf::Scarf> finalize_seam_position(
place_scarf_seam = false; place_scarf_seam = false;
} }
const bool is_overhang{
perimeter.point_classifications[seam_choice.previous_index] == Perimeters::PointClassification::overhang
|| perimeter.point_classifications[seam_choice.next_index] == Perimeters::PointClassification::overhang
};
if (thick_bridges && is_overhang) {
place_scarf_seam = false;
}
if (place_scarf_seam) { if (place_scarf_seam) {
Scarf::Scarf scarf{}; Scarf::Scarf scarf{};
scarf.entire_loop = region->config().scarf_seam_entire_loop; scarf.entire_loop = region->config().scarf_seam_entire_loop;
@ -532,6 +542,8 @@ boost::variant<Point, Scarf::Scarf> Placer::place_seam(
assert(layer->id() >= po->slicing_parameters().raft_layers()); assert(layer->id() >= po->slicing_parameters().raft_layers());
const size_t layer_index = layer->id() - po->slicing_parameters().raft_layers(); const size_t layer_index = layer->id() - po->slicing_parameters().raft_layers();
const bool thick_bridges{po->config().thick_bridges.value};
if (po->config().seam_position.value == spNearest) { if (po->config().seam_position.value == spNearest) {
const std::vector<Perimeters::BoundedPerimeter> &perimeters{ const std::vector<Perimeters::BoundedPerimeter> &perimeters{
this->perimeters_per_layer.at(po)[layer_index]}; this->perimeters_per_layer.at(po)[layer_index]};
@ -539,7 +551,7 @@ boost::variant<Point, Scarf::Scarf> Placer::place_seam(
place_seam_near(perimeters, loop, last_pos, this->params.max_nearest_detour); place_seam_near(perimeters, loop, last_pos, this->params.max_nearest_detour);
return finalize_seam_position( return finalize_seam_position(
loop, region, seam_choice, perimeters[perimeter_index].perimeter, loop, region, seam_choice, perimeters[perimeter_index].perimeter,
this->params.staggered_inner_seams, flipped this->params.staggered_inner_seams, flipped, thick_bridges
); );
} else { } else {
const std::vector<SeamPerimeterChoice> &seams_on_perimeters{this->seams_per_object.at(po)[layer_index]}; const std::vector<SeamPerimeterChoice> &seams_on_perimeters{this->seams_per_object.at(po)[layer_index]};
@ -557,7 +569,7 @@ boost::variant<Point, Scarf::Scarf> Placer::place_seam(
seams_on_perimeters[0]}; seams_on_perimeters[0]};
return finalize_seam_position( return finalize_seam_position(
loop, region, seam_perimeter_choice.choice, seam_perimeter_choice.perimeter, loop, region, seam_perimeter_choice.choice, seam_perimeter_choice.perimeter,
this->params.staggered_inner_seams, flipped this->params.staggered_inner_seams, flipped, thick_bridges
); );
} }
} }
@ -566,7 +578,7 @@ boost::variant<Point, Scarf::Scarf> Placer::place_seam(
choose_closest_seam(seams_on_perimeters, Geometry::to_polygon(loop))}; choose_closest_seam(seams_on_perimeters, Geometry::to_polygon(loop))};
return finalize_seam_position( return finalize_seam_position(
loop, region, seam_perimeter_choice.choice, seam_perimeter_choice.perimeter, loop, region, seam_perimeter_choice.choice, seam_perimeter_choice.perimeter,
this->params.staggered_inner_seams, flipped this->params.staggered_inner_seams, flipped, thick_bridges
); );
} }
} }