5607 Commits

Author SHA1 Message Date
Filip Sykala - NTB T15p
b82f1fe818 Move over surface with relative transformation 2023-02-17 08:16:54 +01:00
Lukas Matena
026ca7b3c9 Fixed wipe tower with no sparse layers (layers were missing) #9592 #9703 2023-02-14 14:02:58 +01:00
YuSanka
4162689a65 Unify Tree/Organic terminology.
+ Implemented Enabling/Disabling for parameters of Organic support
SPE-1478(https://dev.prusa3d.com/browse/SPE-1478)
2023-02-14 10:18:06 +01:00
YuSanka
a913bd493f Fix for #9697 - Cut tool tolerance by measurement 2023-02-13 14:08:21 +01:00
Vojtech Bubnik
8913fdf6ab Reworked AppConfig to mark itself as dirty reliably with any configuration
change and saving AppConfig on idle.
2023-02-13 10:08:12 +01:00
Vojtech Bubnik
db77331004 Slight refactor of Organic supports after merge
3d8f84ed76620790eac798cfa2caf17bf0b08f17
2023-02-10 14:09:47 +01:00
Vojtech Bubnik
3d8f84ed76 Merge remote-tracking branch 'remotes/origin/master' into tr_SuggestedTreeSupportFixes 2023-02-10 12:35:46 +01:00
Lukas Matena
21c76d2e2e Fixed a typo in assert 2023-02-10 12:25:49 +01:00
Thomas Rahm
c9605580ee Fix issue causing some tips to not generate, as remaining_overhang was nearly always empty
Fixes https://github.com/prusa3d/PrusaSlicer/issues/9459
2023-02-09 22:27:30 +01:00
Vojtech Bubnik
f1977b07be Organic supports: Adding bridge detection using the same algorithms
as the regular supports.
Partial fix to #9493
2023-02-09 16:47:57 +01:00
PavelMikus
73635e0855 Lower the curled height tolerance from 0.3 to 0.1 mm of the curled overhang avoidance algorithm. 2023-02-09 13:36:42 +01:00
YuSanka
8b3ff9b9c4 Fix std::optional value() build error on older macOS SDK
For old macOS (pre 10.14), std::optional does not have .value() method, so the code is using operator*() instead.
2023-02-09 09:08:58 +01:00
YuSanka
917c9ad47b Follow-up to 299b01d
Add select_close GUIType and process it
+ Field::Choice: Fix a check of m_opt.enum_def existence
+ Fixed OSX build
2023-02-09 09:08:58 +01:00
Vojtech Bubnik
d58c8b1bbd Refactor of ConfigDef / ConfigOptionDef / PrintConfigDef /
Field and other UI elements to handle enums in a generic way.
Needs a review by @yusanka
2023-02-09 09:08:58 +01:00
Vojtech Bubnik
a1b0188e3a Organic supports: Don't auto generate supports if supports disabled,
but "enforce number of first layers" is enabled.
Fixes #9477
2023-02-08 15:06:39 +01:00
Vojtech Bubnik
9ab88d75e0 Fixing overlaps of organic supports: Base vs. interface layers. 2023-02-08 14:40:50 +01:00
Vojtech Bubnik
56c4cfb202 Fix of supports for soluble / non-soluble after refactoring
of extrusions into islands.
Fixes #9647
2023-02-08 14:40:50 +01:00
PavelMikus
dc1579df04 Apply volumetric speed limits to reference external perimeter speed when using percentage based speeds.
Otherwise it was possible to get higher speeds the extruder limit.
2023-02-08 10:52:06 +01:00
PavelMikus
a167d43c1d Fix bug in GCode markers when dynamic overhang speed is enabled
Should fix the following issues: #9594, #9485, #9563, #9588, #9610
Also fixed a problem with zero speed when dynamic speed was percentage based and speeds were set to 0 (auto)
2023-02-07 17:06:42 +01:00
Vojtech Bubnik
8472287601 Implementing a test whether the current thread is the main (UI) thread
and using it on AppConfig::save() to assert if save is called
from a worker thread.
The old assert was using thread names, which did not always work
on Windows.
Fixes #7839 #9178 #9370 #9420
2023-02-07 16:17:26 +01:00
Vojtech Bubnik
340b685a0d Patching the new Layer::sort_perimeters_into_islands() for super
ugly models.
Fixes #9561, #9562
2023-02-07 13:58:20 +01:00
enricoturri1966
991aedd37c #9597 - GCode processor and GCodeViewer - Fixed extruder temperature after tool changes while using single extruder multi material 2023-02-07 11:25:46 +01:00
PavelMikus
2b1bd627d7 Extra perimeters - minimal change, reduce touch distance in order to improve path sorting
Object stability warning - relfect the state, recommend brim only when it makes sense, and brim is not enabled yet.
2023-02-06 17:06:28 +01:00
Vojtech Bubnik
aaffcbc282 Fixed crash in Organic supports with a single support layer only.
Fixes #9557
2023-02-06 16:52:09 +01:00
Vojtech Bubnik
a97b950c3d Organic supports: Fixed order & orientation of two perimeter loops:
1) All contours are CCW oriented.
2) Inner contours are printed before outer contours.
2023-02-06 16:47:18 +01:00
Lukas Matena
0e1f8bd080 Fixed an UB in CoolingBuffer.cpp: uninitialized var in case that std::from_chars fails:
This fixes CoolingBuffer behavior wrt. 2.5.0 in cases where custom G-Codes contained
lines starting with "T". Those were previously considered as valid toolchanges.
In 2.6.0-alpha3, this scenario led to a hard crash: #9470, #9550
2023-02-06 15:54:33 +01:00
Vojtech Bubnik
7a873201d8 Organic supports: Fixed division by zero for soluble supports
(with zero separation gap between object and supports)
Fixes #9555
2023-02-06 14:58:53 +01:00
PavelMikus
5de05294db Fix extra perimters overlap with infill, there was unecessary additional extrusion
issue: Extra perimeters on overhangs #9604
2023-02-06 11:43:33 +01:00
Vojtech Bubnik
43dc3bfc42 Fix of a crash with sequential print and raft. Fixes #9464 2023-02-03 15:50:15 +01:00
Vojtech Bubnik
5b94971fce Organic supports: Added check for variable layer height, with which
Organic supports are not compatible.
Fixes #9528 and similar.
Moved the object max Z against build volume Z to Print::validate().
Updated layer_height_profile_from_ranges() to compress the resulting
ranges.
2023-02-03 15:27:50 +01:00
Pavel Mikus
79d5a38928 Create validation error when both avoid crossing curled overhangs and avoid crossing perimeters are both enabled together
Update of the previous fix of extra perimeters - do not allow changing the direction of the paths after they have been sorted
2023-02-03 15:25:21 +01:00
Vojtech Bubnik
3cb2f5f58f Fix of Layer::sort_perimeters_into_islands()
Fixes #9466 #9511
2023-02-02 16:43:25 +01:00
PavelMikus
06e602afd3 \#9480 Fix weird path connections in Extra Perimeters when gap fill is applied
\#9513 \#9489 Fix crash when brim is used - the expansion of very small drops may result in empty polygon, which the support spot generator did not reflect
Fix crashes of stability alert checker, when empty print object was passed to it
2023-02-02 14:46:48 +01:00
YuSanka
e4ccfda0b0 Cut: Fix for apply of tolerance to the connectors
Bug was caused by refactoring in 0201a5055a
2023-02-02 12:23:54 +01:00
Vojtech Bubnik
3e1348c062 Organic supports: Reduce memory footprint. 2023-01-31 17:41:36 +01:00
Vojtech Bubnik
49caab98cb Organic supports: Improving smoothing / collision avoidance convergence 2023-01-31 15:55:42 +01:00
PavelMikus
716e0254f4 Fix notifications during GCode export - only CRTICAL are now shown
Relax support detector parameters and warnings
2023-01-31 11:12:36 +01:00
Vojtech Bubnik
6251a880df Enabling zig-zag support intefaces for Organic supports. 2023-01-31 09:41:30 +01:00
Vojtech Bubnik
2a1e12131b Cancellation of tree supports 2023-01-31 09:13:05 +01:00
Lukas Matena
a053d79ca1 Fixed undefined behaviour in Emboss.cpp (reference to temporary) 2023-01-30 10:32:21 +01:00
Pavel Mikus
66a4b5b82a Refactored stability alert step from object step into print step,
implemented stability issues grouping based on number of issues and objects,
maximum of single warning message emitted
2023-01-29 20:11:50 +01:00
Filip Sykala - NTB T15p
db290d8e8d move erase operation out of scope 2023-01-27 15:47:33 +01:00
Filip Sykala - NTB T15p
4e56f75541 Move insert call out of variable scope 2023-01-27 15:27:01 +01:00
PavelMikus
8cb414c262 fix worng step type passed into set-done in new alert step 2023-01-27 15:00:10 +01:00
PavelMikus
05c4e759cf Move checkbox for support alerts into AppConfig preferences.
Separate Alerts into new print object step so that not warnings are thrown for autopaint.
finally fix -1 access int SupportSpotGenerator bridge detection
2023-01-27 15:00:10 +01:00
Vojtech Bubnik
cd0ed00ef5 TREE_SUPPORT_ORGANIC_NUDGE_NEW enabled 2023-01-27 13:50:46 +01:00
Vojtech Bubnik
3e6302d4f3 Organic supports: Patching the missing trees for support enforcers 2023-01-27 13:09:20 +01:00
Lukas Matena
fe39af7d7b Fixed cut gizmo and SLA shift 2023-01-27 12:54:38 +01:00
Vojtech Bubnik
be5149f164 Removed "Tree" support type from UI. 2023-01-27 12:21:12 +01:00
Lukas Matena
ab4655aa40 Fix ooze prevention behaviour on first layer 2023-01-27 12:04:55 +01:00