From 3776b7ed80fcdf17f6bbae7ea3e8edb84c83fe81 Mon Sep 17 00:00:00 2001 From: Alessandro Ranellucci Date: Mon, 5 Nov 2018 20:07:54 +0100 Subject: [PATCH] Bugfix: error in porting of SupportMaterial src/libslic3r/SupportMaterial.cpp:770:17: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] if (!z > top_el.first) // next unless $z > $top_z; ^ ~ src/libslic3r/SupportMaterial.cpp:770:17: note: add parentheses after the '!' to evaluate the comparison first if (!z > top_el.first) // next unless $z > $top_z; ^ ( ) src/libslic3r/SupportMaterial.cpp:770:17: note: add parentheses around left hand side expression to silence this warning if (!z > top_el.first) // next unless $z > $top_z; ^ ( ) 1 warning generated. --- xs/src/libslic3r/SupportMaterial.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xs/src/libslic3r/SupportMaterial.cpp b/xs/src/libslic3r/SupportMaterial.cpp index be97c06b4..ce493e84d 100644 --- a/xs/src/libslic3r/SupportMaterial.cpp +++ b/xs/src/libslic3r/SupportMaterial.cpp @@ -767,7 +767,7 @@ SupportMaterial::generate_bottom_interface_layers(const vector &suppor // surface. for (int layer_id = 0; layer_id < support_z.size(); layer_id++) { auto z = support_z[layer_id]; - if (!z > top_el.first) // next unless $z > $top_z; + if (z <= top_el.first) // next unless $z > $top_z; continue; if (base.count(layer_id) > 0) {