GitHub-Proxy/Slic3r
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/slic3r/Slic3r.git synced 2025-08-14 13:55:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #79

Browse Source 
forget the override keyword: I had virtual function overriding nothing.
This commit is contained in:
supermerill 2019-07-31 18:59:36 +02:00
parent 773972cc2c
commit 5cc2603309
2 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/libslic3r/ExtrusionEntity.hpp
View File

@ -511,12 +511,12 @@ inline void extrusion_entities_append_loops(ExtrusionEntitiesPtr &dst, Polygons
class ExtrusionPrinter : public ExtrusionVisitorConst { class ExtrusionPrinter : public ExtrusionVisitorConst {
std::stringstream ss; std::stringstream ss;
public: public:
virtual void use(const ExtrusionPath &path); virtual void use(const ExtrusionPath &path) override;
virtual void use(const ExtrusionPath3D &path3D); virtual void use(const ExtrusionPath3D &path3D) override;
virtual void use(const ExtrusionMultiPath &multipath); virtual void use(const ExtrusionMultiPath &multipath) override;
virtual void use(const ExtrusionMultiPath3D &multipath); virtual void use(const ExtrusionMultiPath3D &multipath) override;
virtual void use(const ExtrusionLoop &loop); virtual void use(const ExtrusionLoop &loop) override;
virtual void use(const ExtrusionEntityCollection &collection); virtual void use(const ExtrusionEntityCollection &collection) override;
std::string str() { return ss.str(); } std::string str() { return ss.str(); }
std::string print(const ExtrusionEntity &entity) && { std::string print(const ExtrusionEntity &entity) && {
entity.visit(*this); entity.visit(*this);

14
src/libslic3r/SupportMaterial.cpp
View File

@ -2674,15 +2674,15 @@ static std::string dbg_index_to_color(int idx)
} }
#endif /* SLIC3R_DEBUG */ #endif /* SLIC3R_DEBUG */
class GetFirstPath : public ExtrusionVisitor { class GetFirstPath : public ExtrusionVisitorConst {
public: public:
const ExtrusionPath *extrusion_path_template = nullptr; const ExtrusionPath *extrusion_path_template = nullptr;
virtual void use(const ExtrusionPath &path) { extrusion_path_template = &path; } virtual void use(const ExtrusionPath &path) override { extrusion_path_template = &path; }
virtual void use(const ExtrusionPath3D &path3D) { extrusion_path_template = &path3D; } virtual void use(const ExtrusionPath3D &path3D) override { extrusion_path_template = &path3D; }
virtual void use(const ExtrusionMultiPath &multipath) { if (!multipath.paths.empty()) extrusion_path_template = &multipath.paths.front(); } virtual void use(const ExtrusionMultiPath &multipath) override { if (!multipath.paths.empty()) extrusion_path_template = &multipath.paths.front(); }
virtual void use(const ExtrusionMultiPath3D &multipath) { if (!multipath.paths.empty()) extrusion_path_template = &multipath.paths.front(); } virtual void use(const ExtrusionMultiPath3D &multipath) override { if (!multipath.paths.empty()) extrusion_path_template = &multipath.paths.front(); }
virtual void use(const ExtrusionLoop &loop) { if (!loop.paths.empty()) extrusion_path_template = &loop.paths.front(); } virtual void use(const ExtrusionLoop &loop) override { if (!loop.paths.empty()) extrusion_path_template = &loop.paths.front(); }
virtual void use(const ExtrusionEntityCollection &collection) { virtual void use(const ExtrusionEntityCollection &collection) override {
auto it = collection.entities.begin(); auto it = collection.entities.begin();
while (extrusion_path_template == nullptr && it != collection.entities.end()) { while (extrusion_path_template == nullptr && it != collection.entities.end()) {
(*it)->visit(*this); (*it)->visit(*this);