From 1a92aeec2ab252401846231639447326507f430e Mon Sep 17 00:00:00 2001 From: Joseph Lenox Date: Fri, 9 Nov 2018 22:13:35 -0600 Subject: [PATCH] Use wxChoice instead of wxComboBox with readonly if the readonly bit is set for select_open types. Fixes #4584 (UX issue on MacOS with wxCombobox/wxChoice) --- lib/Slic3r/GUI/OptionsGroup/Field.pm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/Slic3r/GUI/OptionsGroup/Field.pm b/lib/Slic3r/GUI/OptionsGroup/Field.pm index 638612116..021e35c67 100644 --- a/lib/Slic3r/GUI/OptionsGroup/Field.pm +++ b/lib/Slic3r/GUI/OptionsGroup/Field.pm @@ -223,9 +223,14 @@ sub BUILD { my ($self) = @_; my $style = 0; - $style |= wxCB_READONLY if defined $self->option->gui_type && $self->option->gui_type ne 'select_open'; - my $field = Wx::ComboBox->new($self->parent, -1, "", wxDefaultPosition, $self->_default_size, - $self->option->labels || $self->option->values || [], $style); + my $field = 0; + if (defined $self->option->gui_type && $self->option->gui_type ne 'select_open') { + $field = Wx::Choice->new($self->parent, -1, wxDefaultPosition, $self->_default_size, + $self->option->labels || $self->option->values || [], $style); + } else { + $field = Wx::ComboBox->new($self->parent, -1, "", wxDefaultPosition, $self->_default_size, + $self->option->labels || $self->option->values || [], $style); + } $self->wxWindow($field); $self->set_value($self->option->default);