GitHub-Proxy/Slic3r
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/slic3r/Slic3r.git synced 2025-08-18 02:35:57 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bugfix: crash when optimizing bridges. #3928

Browse Source
This commit is contained in:
Alessandro Ranellucci 2017-05-08 21:09:37 +02:00
parent 1d97698270
commit 788cbebcfc
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
xs/src/libslic3r/LayerRegion.cpp
View File

@ -74,17 +74,17 @@ LayerRegion::process_external_surfaces()
Surfaces &surfaces = this->fill_surfaces.surfaces; Surfaces &surfaces = this->fill_surfaces.surfaces;
for (size_t j = 0; j < surfaces.size(); ++j) { for (size_t j = 0; j < surfaces.size(); ++j) {
Surface &surface = surfaces[j]; // we don't get any reference to surface because it would be invalidated
// by the erase() call below
if (this->layer()->lower_layer != NULL && surface.is_bridge()) { if (this->layer()->lower_layer != NULL && surfaces[j].is_bridge()) {
// If this bridge has one or more holes that are internal surfaces // If this bridge has one or more holes that are internal surfaces
// (thus not visible from the outside), like a slab sustained by // (thus not visible from the outside), like a slab sustained by
// pillars, include them in the bridge in order to have better and // pillars, include them in the bridge in order to have better and
// more continuous bridging. // more continuous bridging.
Polygons &holes = surface.expolygon.holes; for (int i = 0; i < surfaces[j].expolygon.holes.size(); ++i) {
for (int i = 0; i < holes.size(); ++i) {
// reverse the hole and consider it a polygon // reverse the hole and consider it a polygon
Polygon h = holes[i]; Polygon h = surfaces[j].expolygon.holes[i];
h.reverse(); h.reverse();
// Is this hole fully contained in the layer slices? // Is this hole fully contained in the layer slices?
@ -94,10 +94,12 @@ LayerRegion::process_external_surfaces()
if (k == j) continue; if (k == j) continue;
if (h.contains(surfaces[k].expolygon.contour.first_point())) { if (h.contains(surfaces[k].expolygon.contour.first_point())) {
surfaces.erase(surfaces.begin() + k); surfaces.erase(surfaces.begin() + k);
if (j > k) --j;
--k; --k;
} }
} }
Polygons &holes = surfaces[j].expolygon.holes;
holes.erase(holes.begin() + i); holes.erase(holes.begin() + i);
--i; --i;
} }