GitHub-Proxy/Slic3r
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/slic3r/Slic3r.git synced 2025-08-14 05:25:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bugfix: the "complete individual object" checker is now sane.

Browse Source
This commit is contained in:
supermerill 2019-03-06 22:59:48 +01:00
parent 3bf48193de
commit 86fe7e333f
1 changed files with 55 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
src/libslic3r/Print.cpp
View File

@ -12,6 +12,8 @@
#include "PrintExport.hpp" #include "PrintExport.hpp"
#include <libnest2d.h>
#include <algorithm> #include <algorithm>
#include <limits> #include <limits>
#include <unordered_set> #include <unordered_set>
@ -1134,29 +1136,63 @@ std::string Print::validate() const
{ {
Polygons convex_hulls_other; Polygons convex_hulls_other;
for (const PrintObject *object : m_objects) { for (const PrintObject *object : m_objects) {
// Get convex hull of all meshes assigned to this print object.
Polygon convex_hull; // Get the 2D projected shapes with their 3D model instance pointers
//same method from ModelArrange.cpp. It's copy-pasted.
// TODO: make a generic method used by that and modelarrange.
ClipperLib::Path clpath;
{ {
Polygons mesh_convex_hulls; TriangleMesh rmesh = object->model_object()->raw_mesh();
for (const std::vector<int> &volumes : object->region_volumes) ModelInstance * finst = object->model_object()->instances.front();
for (int volume_id : volumes) // Object instances should carry the same scaling and
mesh_convex_hulls.emplace_back(object->model_object()->volumes[volume_id]->mesh.convex_hull()); // x, y rotation that is why we use the first instance.
// make a single convex hull for all of them // The next line will apply only the full mirroring and scaling
convex_hull = Slic3r::Geometry::convex_hull(mesh_convex_hulls); rmesh.transform(finst->get_matrix(true, true, false, false));
rmesh.rotate_x(float(finst->get_rotation()(X)));
rmesh.rotate_y(float(finst->get_rotation()(Y)));
// TODO export the exact 2D projection. Cannot do it as libnest2d
// does not support concave shapes (yet).
auto p = rmesh.convex_hull();
p.make_clockwise();
p.append(p.first_point());
clpath = Slic3rMultiPoint_to_ClipperPath(p);
} }
// Apply the same transformations we apply to the actual meshes when slicing them.
object->model_object()->instances.front()->transform_polygon(&convex_hull); std::vector<libnest2d::Item> convex_hull_items;
// Grow convex hull with the clearance margin. for (ModelInstance* objinst : object->model_object()->instances) {
// FIXME: Arrangement has different parameters for offsetting (jtMiter, limit 2) if (objinst) {
// which causes that the warning will be showed after arrangement with the ClipperLib::PolygonImpl pn;
// appropriate object distance. Even if I set this to jtMiter the warning still shows up. pn.Contour = clpath;
convex_hull = offset(convex_hull, scale_(m_config.extruder_clearance_radius.value)/2, jtRound, scale_(0.1)).front(); // Efficient conversion to item.
libnest2d::Item item(std::move(pn));
// Invalid geometries would throw exceptions when arranging
if (item.vertexCount() > 3) {
item.rotation(objinst->get_rotation(Z));
item.translation({
ClipperLib::cInt(objinst->get_offset(X) / SCALING_FACTOR),
ClipperLib::cInt(objinst->get_offset(Y) / SCALING_FACTOR)
});
convex_hull_items.push_back(item);
}
}
}
Polygons convex_hull;
for (libnest2d::Item &item : convex_hull_items){
//conversion to Polygons
ClipperLib::PolygonImpl var = item;
ClipperLib::Path cont = var.Contour;
convex_hull.push_back(ClipperPath_to_Slic3rPolygon(cont));
}
// Now we check that no instance of convex_hull intersects any of the previously checked object instances. // Now we check that no instance of convex_hull intersects any of the previously checked object instances.
for (const Point &copy : object->m_copies) { for (Polygon p : convex_hull){
Polygon p = convex_hull; // Grow convex hull with the clearance margin.
p.translate(copy); p = offset(p, scale_(m_config.extruder_clearance_radius.value) / 2, jtRound, scale_(0.1)).front();
if (! intersection(convex_hulls_other, p).empty()) if (!intersection(convex_hulls_other, p).empty()){
return L("Some objects are too close; your extruder will collide with them."); return L("Some objects are too close; your extruder will collide with them.");
}
polygons_append(convex_hulls_other, p); polygons_append(convex_hulls_other, p);
} }
} }