GitHub-Proxy/Slic3r
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/slic3r/Slic3r.git synced 2025-08-16 06:45:52 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bad check for default_acceleration when diabled and exporting config.

Browse Source 
supermerill/SuperSlicer#1622
This commit is contained in:
supermerill 2021-10-10 15:28:07 +02:00
parent 37838be7cf
commit 9328681428
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libslic3r/PrintConfig.cpp
View File

@ -6482,6 +6482,7 @@ std::set<const DynamicPrintConfig*> DynamicPrintConfig::value_changed(const t_co
} }
//FIXME localize this function. //FIXME localize this function.
//note: seems only called for config export & command line. Most of the validation work for the gui is done elsewhere... So this function may be a bit out-of-sync
std::string FullPrintConfig::validate() std::string FullPrintConfig::validate()
{ {
// --layer-height // --layer-height
@ -6558,7 +6559,7 @@ std::string FullPrintConfig::validate()
// --fill-density // --fill-density
if (fabs(this->fill_density.value - 100.) < EPSILON && if (fabs(this->fill_density.value - 100.) < EPSILON &&
(! print_config_def.get("top_fill_pattern")->has_enum_value(this->fill_pattern.serialize()) (! print_config_def.get("top_fill_pattern")->has_enum_value(this->fill_pattern.serialize())
|| ! print_config_def.get("bottom_fill_pattern")->has_enum_value(this->fill_pattern.serialize()) && ! print_config_def.get("bottom_fill_pattern")->has_enum_value(this->fill_pattern.serialize())
)) ))
return "The selected fill pattern is not supposed to work at 100% density"; return "The selected fill pattern is not supposed to work at 100% density";
@ -6581,11 +6582,6 @@ std::string FullPrintConfig::validate()
if (em <= 0) if (em <= 0)
return "Invalid value for --extrusion-multiplier"; return "Invalid value for --extrusion-multiplier";
// --default-acceleration
if ((this->perimeter_acceleration.value != 0. || this->infill_acceleration.value != 0. || this->bridge_acceleration.value != 0. || this->first_layer_acceleration.value != 0.) &&
this->default_acceleration.value == 0.)
return "Invalid zero value for --default-acceleration when using other acceleration settings";
// --spiral-vase // --spiral-vase
if (this->spiral_vase) { if (this->spiral_vase) {
// Note that we might want to have more than one perimeter on the bottom // Note that we might want to have more than one perimeter on the bottom