GitHub-Proxy/Slic3r
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/slic3r/Slic3r.git synced 2025-07-31 17:12:00 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed input to bed shape dialog to catch everything that resolves to 0. Fixes #3681 (#3683)

Browse Source
This commit is contained in:
Joseph Lenox 2017-02-07 16:46:54 -06:00 committed by GitHub
parent d41e3c1ee4
commit c557a00516
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Slic3r/GUI/BedShapeDialog.pm
View File

@ -212,9 +212,9 @@ sub _update_shape {
my $rect_origin = $self->{optgroups}[SHAPE_RECTANGULAR]->get_value('rect_origin'); my $rect_origin = $self->{optgroups}[SHAPE_RECTANGULAR]->get_value('rect_origin');
my ($x, $y) = @$rect_size; my ($x, $y) = @$rect_size;
return if !looks_like_number($x) || !looks_like_number($y); # empty strings or '-' or other things return if !looks_like_number($x) || !looks_like_number($y); # empty strings or '-' or other things
return if !$x || !$y; return if !$x || !$y or $x == 0 or $y == 0;
my ($x0, $y0) = (0,0); my ($x0, $y0) = (0,0);
my ($x1, $y1) = ($x,$y); my ($x1, $y1) = ($x ,$y);
{ {
my ($dx, $dy) = @$rect_origin; my ($dx, $dy) = @$rect_origin;
return if !looks_like_number($dx) || !looks_like_number($dy); # empty strings or '-' or other things return if !looks_like_number($dx) || !looks_like_number($dy); # empty strings or '-' or other things
@ -231,7 +231,7 @@ sub _update_shape {
]); ]);
} elsif ($page_idx == SHAPE_CIRCULAR) { } elsif ($page_idx == SHAPE_CIRCULAR) {
my $diameter = $self->{optgroups}[SHAPE_CIRCULAR]->get_value('diameter'); my $diameter = $self->{optgroups}[SHAPE_CIRCULAR]->get_value('diameter');
return if !$diameter; return if !$diameter or $diameter == 0;
my $r = $diameter/2; my $r = $diameter/2;
my $twopi = 2*PI; my $twopi = 2*PI;
my $edges = 60; my $edges = 60;