GitHub-Proxy/Slic3r
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/slic3r/Slic3r.git synced 2025-08-14 17:26:00 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-Authored-By: alranel <aar@cpan.org>
This commit is contained in:
Joseph Lenox 2018-11-29 07:11:35 +01:00
parent 79d0677db2
commit dd38214884
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/libslic3r/test_config.cpp
View File

@ -14,13 +14,7 @@ SCENARIO("Generic config validation performs as expected.") {
WHEN( "perimeter_extrusion_width is set to 250%, a valid value") { WHEN( "perimeter_extrusion_width is set to 250%, a valid value") {
config->set("perimeter_extrusion_width", "250%"); config->set("perimeter_extrusion_width", "250%");
THEN( "The config is read as valid.") { THEN( "The config is read as valid.") {
auto except_thrown {false}; REQUIRE_NOTHROW(config->validate());
try {
config->validate();
} catch (const InvalidOptionException& e) {
except_thrown = true;
}
REQUIRE(except_thrown == false);
} }
} }
WHEN( "perimeter_extrusion_width is set to -10, an invalid value") { WHEN( "perimeter_extrusion_width is set to -10, an invalid value") {
@ -168,7 +162,7 @@ SCENARIO("Config accessor functions perform as expected.") {
} }
WHEN("An invalid option is requested during get.") { WHEN("An invalid option is requested during get.") {
THEN("A BadOptionTypeException exception is thrown.") { THEN("A UnknownOptionException exception is thrown.") {
REQUIRE_THROWS_AS(config->get<ConfigOptionString>("deadbeef_invalid_option", false), UnknownOptionException); REQUIRE_THROWS_AS(config->get<ConfigOptionString>("deadbeef_invalid_option", false), UnknownOptionException);
REQUIRE_THROWS_AS(config->get<ConfigOptionFloat>("deadbeef_invalid_option", false), UnknownOptionException); REQUIRE_THROWS_AS(config->get<ConfigOptionFloat>("deadbeef_invalid_option", false), UnknownOptionException);
REQUIRE_THROWS_AS(config->get<ConfigOptionInt>("deadbeef_invalid_option", false), UnknownOptionException); REQUIRE_THROWS_AS(config->get<ConfigOptionInt>("deadbeef_invalid_option", false), UnknownOptionException);
@ -176,7 +170,7 @@ SCENARIO("Config accessor functions perform as expected.") {
} }
} }
WHEN("An invalid option is requested during get_ptr.") { WHEN("An invalid option is requested during get_ptr.") {
THEN("A BadOptionTypeException exception is thrown.") { THEN("A UnknownOptionException exception is thrown.") {
REQUIRE_THROWS_AS(config->get_ptr<ConfigOptionString>("deadbeef_invalid_option", false), UnknownOptionException); REQUIRE_THROWS_AS(config->get_ptr<ConfigOptionString>("deadbeef_invalid_option", false), UnknownOptionException);
REQUIRE_THROWS_AS(config->get_ptr<ConfigOptionFloat>("deadbeef_invalid_option", false), UnknownOptionException); REQUIRE_THROWS_AS(config->get_ptr<ConfigOptionFloat>("deadbeef_invalid_option", false), UnknownOptionException);
REQUIRE_THROWS_AS(config->get_ptr<ConfigOptionInt>("deadbeef_invalid_option", false), UnknownOptionException); REQUIRE_THROWS_AS(config->get_ptr<ConfigOptionInt>("deadbeef_invalid_option", false), UnknownOptionException);