From ea67f8ca4f57b045de1324d4359ad4b875e4120e Mon Sep 17 00:00:00 2001
From: Alessandro Ranellucci <aar@cpan.org>
Date: Sun, 25 Nov 2018 18:16:20 +0100
Subject: [PATCH] Bugfix: Model::add_default_instances() was always return true

---
 xs/src/libslic3r/Model.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/xs/src/libslic3r/Model.cpp b/xs/src/libslic3r/Model.cpp
index 973472a7e..9fc92c528 100644
--- a/xs/src/libslic3r/Model.cpp
+++ b/xs/src/libslic3r/Model.cpp
@@ -185,12 +185,14 @@ bool
 Model::add_default_instances()
 {
     // apply a default position to all objects not having one
-    for (ModelObjectPtrs::const_iterator o = this->objects.begin(); o != this->objects.end(); ++o) {
-        if ((*o)->instances.empty()) {
-            (*o)->add_instance();
+    bool added = false;
+    for (ModelObject* o : this->objects) {
+        if (o->instances.empty()) {
+            o->add_instance();
+            added = true;
         }
     }
-    return true;
+    return added;
 }
 
 // this returns the bounding box of the *transformed* instances