From dd93de0bfc8165b8676c6e5045477290077fbf85 Mon Sep 17 00:00:00 2001
From: Rakshith R <rar@redhat.com>
Date: Mon, 2 Jun 2025 17:34:26 +0530
Subject: [PATCH] util: pass Servers by reference to Start()

This commit modifies nonBlockingGRPCServer.Start()
to accept Servers parameter by reference rather
than value to prevent copy of a large struct.

Signed-off-by: Rakshith R <rar@redhat.com>
---
 internal/cephfs/driver.go     | 2 +-
 internal/csi-common/server.go | 6 +++---
 internal/nfs/driver/driver.go | 2 +-
 internal/rbd/driver/driver.go | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/internal/cephfs/driver.go b/internal/cephfs/driver.go
index d6b38f3f1..6591e6677 100644
--- a/internal/cephfs/driver.go
+++ b/internal/cephfs/driver.go
@@ -193,7 +193,7 @@ func (fs *Driver) Run(conf *util.Config) {
 	}
 
 	server := csicommon.NewNonBlockingGRPCServer()
-	srv := csicommon.Servers{
+	srv := &csicommon.Servers{
 		IS: fs.is,
 		CS: fs.cs,
 		NS: fs.ns,
diff --git a/internal/csi-common/server.go b/internal/csi-common/server.go
index b758f8d4a..543ee8e0d 100644
--- a/internal/csi-common/server.go
+++ b/internal/csi-common/server.go
@@ -31,7 +31,7 @@ import (
 // NonBlockingGRPCServer defines Non blocking GRPC server interfaces.
 type NonBlockingGRPCServer interface {
 	// Start services at the endpoint
-	Start(endpoint string, srv Servers, middlewareConfig MiddlewareServerOptionConfig)
+	Start(endpoint string, srv *Servers, middlewareConfig MiddlewareServerOptionConfig)
 	// Waits for the service to stop
 	Wait()
 	// Stops the service gracefully
@@ -62,11 +62,11 @@ type nonBlockingGRPCServer struct {
 // Start start service on endpoint.
 func (s *nonBlockingGRPCServer) Start(
 	endpoint string,
-	srv Servers,
+	srv *Servers,
 	middlewareConfig MiddlewareServerOptionConfig,
 ) {
 	s.wg.Add(1)
-	go s.serve(endpoint, srv, middlewareConfig)
+	go s.serve(endpoint, *srv, middlewareConfig)
 }
 
 // Wait blocks until the WaitGroup counter.
diff --git a/internal/nfs/driver/driver.go b/internal/nfs/driver/driver.go
index 890fba815..5f5df821d 100644
--- a/internal/nfs/driver/driver.go
+++ b/internal/nfs/driver/driver.go
@@ -63,7 +63,7 @@ func (fs *Driver) Run(conf *util.Config) {
 
 	// Create gRPC servers
 	server := csicommon.NewNonBlockingGRPCServer()
-	srv := csicommon.Servers{
+	srv := &csicommon.Servers{
 		IS: identity.NewIdentityServer(cd),
 	}
 
diff --git a/internal/rbd/driver/driver.go b/internal/rbd/driver/driver.go
index 4db008302..fbaaa0fd2 100644
--- a/internal/rbd/driver/driver.go
+++ b/internal/rbd/driver/driver.go
@@ -189,7 +189,7 @@ func (r *Driver) Run(conf *util.Config) {
 	}
 
 	s := csicommon.NewNonBlockingGRPCServer()
-	srv := csicommon.Servers{
+	srv := &csicommon.Servers{
 		IS: r.ids,
 		CS: r.cs,
 		NS: r.ns,