GitHub-Proxy/draco
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/google/draco synced 2025-08-12 12:39:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid comparing bool using the < and > operator (#817)

Browse Source 
There is no need to perform the check if T is of type bool, since it is guaranteed to fit in all other integral types.

This avoids triggering a C4804 warning in Visual Studio, ie. `unsafe use of type 'bool' in operation`
This commit is contained in:
Björn Blissing 2022-02-26 05:46:51 +01:00 committed by GitHub
parent bd1e8de7dd
commit 43ada9a7f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/draco/attributes/geometry_attribute.h
View File

@ -284,7 +284,8 @@ class GeometryAttribute {
// Make sure the in_value fits within the range of values that OutT
// is able to represent. Perform the check only for integral types.
if (std::is_integral<T>::value && std::is_integral<OutT>::value) {
if (!std::is_same<T, bool>::value && std::is_integral<T>::value &&
std::is_integral<OutT>::value) {
static constexpr OutT kOutMin =
std::is_signed<T>::value ? std::numeric_limits<OutT>::lowest() : 0;
if (in_value < kOutMin || in_value > std::numeric_limits<OutT>::max()) {