GitHub-Proxy/draco
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/google/draco synced 2025-08-11 03:18:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

draco: Fix add_cxx_preproc_definition() behavior/usage to support setting multiple opts

Browse Source 
- Prev, only last option would take/be appended ... results in needing to
  run build bunches of times and exploding the CMAKE_CXX_FLAGS variable
- We also no longer cache those definitions, keeping them localized
- Ref: https://github.com/google/draco/issues/306 for related discussion
   - Linked fix uses CMake add_definitions() function, but this applies to
     both C and C++-based compilation
This commit is contained in:
David Scherba 2017-11-27 15:55:50 -06:00 committed by Brad Davis
parent 0438f97edf
commit 85cbcbf7b0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmake/compiler_flags.cmake
View File

@ -152,8 +152,7 @@ function (add_cxx_preproc_definition preproc_def)
string(FIND "${CMAKE_CXX_FLAGS}" "${preproc_def}" PREPROC_DEF_FOUND) string(FIND "${CMAKE_CXX_FLAGS}" "${preproc_def}" PREPROC_DEF_FOUND)
if (${PREPROC_DEF_FOUND} EQUAL -1) if (${PREPROC_DEF_FOUND} EQUAL -1)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D${preproc_def}" CACHE STRING "" set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D${preproc_def}" PARENT_SCOPE)
FORCE)
endif () endif ()
endfunction () endfunction ()