From 8870614628f246b385b657dd73650758a8afbf62 Mon Sep 17 00:00:00 2001 From: Frank Galligan Date: Sun, 1 Oct 2017 15:56:21 -0700 Subject: [PATCH] A few small fixes for the spec. This is associated with #134 --- docs/spec/04.00.00.conventions.md | 9 ++++----- docs/spec/prediction.wrap.transform.md | 2 +- docs/spec/sequential.integer.attribute.decoder.md | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/spec/04.00.00.conventions.md b/docs/spec/04.00.00.conventions.md index 38aee2a..12d8e2c 100644 --- a/docs/spec/04.00.00.conventions.md +++ b/docs/spec/04.00.00.conventions.md @@ -5,6 +5,8 @@ * When bit reading is finished it will always pad the read to the current byte. + * varUI32 and varUI64 types must be decoded by the DecodeVarint() function. + * Draco encoded mesh files are comprised of three main sections. This first section is the header. The second section contains the connectivity data. The third section contains the attribute data. The header must be decoded @@ -22,9 +24,9 @@ * Context data for the valence prediction - * Hole and Split data + * Split data - * The hole and split data must be decoded before the EdgeBreaker symbols are + * The split data must be decoded before the EdgeBreaker symbols are decoded. ### Method of describing bitstream syntax @@ -39,9 +41,6 @@ from syntax elements values. {% comment %} -**FIXME: This section is borrowed from AV1, and should be modified for the Draco -spec.** - The description style of the syntax is similar to the C++ programming language. Syntax elements in the bitstream are represented in bold type. Each syntax element is described by its name (using only lower case letters with diff --git a/docs/spec/prediction.wrap.transform.md b/docs/spec/prediction.wrap.transform.md index 63cd408..9019ad6 100644 --- a/docs/spec/prediction.wrap.transform.md +++ b/docs/spec/prediction.wrap.transform.md @@ -8,7 +8,7 @@ void PredictionSchemeWrapTransformBase_ClampPredictedValue(predicted_val, num_components = GetNumComponents(); min_value_ = pred_trasnform_wrap_min[curr_att_dec][curr_att]; max_value_ = pred_trasnform_wrap_max[curr_att_dec][curr_att]; - for (int i = 0; i < num_components; ++i) { + for (i = 0; i < num_components; ++i) { if (predicted_val[i] > max_value_) clamped_value_[i] = max_value_; else if (predicted_val[i] < min_value_) diff --git a/docs/spec/sequential.integer.attribute.decoder.md b/docs/spec/sequential.integer.attribute.decoder.md index 751687c..6e0ba5d 100644 --- a/docs/spec/sequential.integer.attribute.decoder.md +++ b/docs/spec/sequential.integer.attribute.decoder.md @@ -46,7 +46,7 @@ void SequentialIntegerAttributeDecoder_DecodeIntegerValues() { if (seq_att_dec_prediction_transform_type[curr_att_dec][curr_att] == PREDICTION_TRANSFORM_NORMAL_OCTAHEDRON_CANONICALIZED) { decoded_symbols = seq_int_att_dec_decoded_values[curr_att_dec][curr_att]; - for (int i = 0; i < decoded_symbols.size(); ++i) { + for (i = 0; i < decoded_symbols.size(); ++i) { signed_vals[i] = decoded_symbols[i]; } seq_int_att_dec_symbols_to_signed_ints[curr_att_dec][curr_att] = signed_vals;