From d4675cf0d12c3f60f7d1d425801200e44ee90150 Mon Sep 17 00:00:00 2001 From: Tom Finegan Date: Thu, 24 May 2018 10:20:36 -0700 Subject: [PATCH] cmake: Fix mac build Clang @ Apple LLVM version 9.0.0 (clang-900.0.39.2) fails to link when SOVERSION is set for bundles. Don't set it on Apple targets. --- CMakeLists.txt | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ad55545..17a2272 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -798,8 +798,6 @@ else () add_library(draco_maya_plugin OBJECT ${draco_maya_plug_sources}) - - # Library targets that consume the object collections. add_library(dracodec ${draco_version_sources} @@ -888,28 +886,28 @@ else () MODULE ${draco_version_sources} $ - $ + $ $ $ $ $ $ - $ - $ - $ - $ + $ + $ + $ + $ $ $ $ - $ + $ $ $ $ $ $ $ - $ - $) + $ + $) # For Mac, we need to build a .bundle for plugin. if (APPLE) @@ -917,8 +915,6 @@ else () endif () endif () - - set(draco_header_only_targets draco_compression_attributes_pred_schemes_dec draco_dec_config @@ -936,7 +932,7 @@ else () if (BUILD_UNITY_PLUGIN AND (NOT APPLE)) set_target_properties(dracodec_unity PROPERTIES SOVERSION 1) endif () - if (BUILD_MAYA_PLUGIN) + if (BUILD_MAYA_PLUGIN AND (NOT APPLE)) set_target_properties(draco_maya_wrapper PROPERTIES SOVERSION 1) endif () endif ()