GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-05-07 03:39:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

forward port fix to #12

Browse Source
This commit is contained in:
Benoit Jacob 2009-06-19 18:51:15 +02:00
parent a57325e971
commit 032594cee2
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Eigen/src/QR/Tridiagonalization.h
View File

@ -205,6 +205,7 @@ void Tridiagonalization<MatrixType>::_compute(MatrixType& matA, CoeffVectorType&
// squared norm of the vector v skipping the first element // squared norm of the vector v skipping the first element
RealScalar v1norm2 = matA.col(i).end(n-(i+2)).squaredNorm(); RealScalar v1norm2 = matA.col(i).end(n-(i+2)).squaredNorm();
// FIXME comparing against 1
if (ei_isMuchSmallerThan(v1norm2,static_cast<Scalar>(1))) if (ei_isMuchSmallerThan(v1norm2,static_cast<Scalar>(1)))
{ {
hCoeffs.coeffRef(i) = 0.; hCoeffs.coeffRef(i) = 0.;
@ -253,10 +254,12 @@ void Tridiagonalization<MatrixType>::_compute(MatrixType& matA, CoeffVectorType&
int i = n-2; int i = n-2;
Scalar v0 = matA.col(i).coeff(i+1); Scalar v0 = matA.col(i).coeff(i+1);
RealScalar beta = ei_abs(v0); RealScalar beta = ei_abs(v0);
if (ei_real(v0)>=0.) if (ei_real(v0)>=RealScalar(0))
beta = -beta; beta = -beta;
matA.col(i).coeffRef(i+1) = beta; matA.col(i).coeffRef(i+1) = beta;
hCoeffs.coeffRef(i) = (beta - v0) / beta; // FIXME comparing against 1
if(ei_isMuchSmallerThan(beta, Scalar(1))) hCoeffs.coeffRef(i) = Scalar(0);
else hCoeffs.coeffRef(i) = (beta - v0) / beta;
} }
else else
{ {