GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-06-04 18:54:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

quick temporary fix for a perf issue we just identified with

Browse Source 
vectorization....
now the sum benchmark runs 3x faster with vectorization than without.
This commit is contained in:
Benoit Jacob 2008-06-23 11:23:05 +00:00
parent 32596c5e9e
commit 03d19f3bae
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Eigen/src/Core/Sum.h
View File

@ -194,17 +194,32 @@ struct ei_sum_impl<Derived, LinearVectorization, NoUnrolling>
// do the vectorizable part of the sum // do the vectorizable part of the sum
if(size >= packetSize) if(size >= packetSize)
{ {
asm("#begin");
PacketScalar packet_res; PacketScalar packet_res;
packet_res = mat.template packet<Aligned>(0, 0); packet_res = mat.template packet<Aligned>(0, 0);
int index; int index;
for(index = packetSize; index<alignedSize ; index+=packetSize) if(Derived::IsVectorAtCompileTime)
{ {
// FIXME the following is not really efficient for(index = packetSize; index<alignedSize ; index+=packetSize)
const int row = rowMajor ? index/innerSize : index%innerSize; {
const int col = rowMajor ? index%innerSize : index/innerSize; const int row = Derived::RowsAtCompileTime==1 ? 0 : index;
packet_res = ei_padd(packet_res, mat.template packet<Aligned>(row, col)); const int col = Derived::RowsAtCompileTime==1 ? index : 0;
packet_res = ei_padd(packet_res, mat.template packet<Aligned>(row, col));
}
}
else
{
for(index = packetSize; index<alignedSize ; index+=packetSize)
{
// FIXME the following is not really efficient
const int row = rowMajor ? index/innerSize : index%innerSize;
const int col = rowMajor ? index%innerSize : index/innerSize;
packet_res = ei_padd(packet_res, mat.template packet<Aligned>(row, col));
}
} }
res = ei_predux(packet_res); res = ei_predux(packet_res);
asm("#end");
// now we must do the rest without vectorization. // now we must do the rest without vectorization.
if(alignedSize == size) return res; if(alignedSize == size) return res;