diff --git a/Eigen/src/Core/Dot.h b/Eigen/src/Core/Dot.h index 16496273c..0d8856efa 100644 --- a/Eigen/src/Core/Dot.h +++ b/Eigen/src/Core/Dot.h @@ -41,18 +41,20 @@ template struct dot_nocheck { - static inline typename traits::Scalar run(const MatrixBase& a, const MatrixBase& b) + typedef typename scalar_product_traits::Scalar,typename traits::Scalar>::ReturnType ResScalar; + static inline ResScalar run(const MatrixBase& a, const MatrixBase& b) { - return a.template binaryExpr::Scalar> >(b).sum(); + return a.template binaryExpr::Scalar,typename traits::Scalar> >(b).sum(); } }; template struct dot_nocheck { - static inline typename traits::Scalar run(const MatrixBase& a, const MatrixBase& b) + typedef typename scalar_product_traits::Scalar,typename traits::Scalar>::ReturnType ResScalar; + static inline ResScalar run(const MatrixBase& a, const MatrixBase& b) { - return a.transpose().template binaryExpr::Scalar> >(b).sum(); + return a.transpose().template binaryExpr::Scalar,typename traits::Scalar> >(b).sum(); } }; @@ -70,14 +72,14 @@ struct dot_nocheck */ template template -typename internal::traits::Scalar +typename internal::scalar_product_traits::Scalar,typename internal::traits::Scalar>::ReturnType MatrixBase::dot(const MatrixBase& other) const { EIGEN_STATIC_ASSERT_VECTOR_ONLY(Derived) EIGEN_STATIC_ASSERT_VECTOR_ONLY(OtherDerived) EIGEN_STATIC_ASSERT_SAME_VECTOR_SIZE(Derived,OtherDerived) - EIGEN_STATIC_ASSERT((internal::is_same::value), - YOU_MIXED_DIFFERENT_NUMERIC_TYPES__YOU_NEED_TO_USE_THE_CAST_METHOD_OF_MATRIXBASE_TO_CAST_NUMERIC_TYPES_EXPLICITLY) + typedef internal::scalar_conj_product_op func; + EIGEN_CHECK_BINARY_COMPATIBILIY(func,Scalar,typename OtherDerived::Scalar); eigen_assert(size() == other.size()); diff --git a/Eigen/src/Core/Functors.h b/Eigen/src/Core/Functors.h index 325a7dd85..917769c9e 100644 --- a/Eigen/src/Core/Functors.h +++ b/Eigen/src/Core/Functors.h @@ -59,6 +59,7 @@ struct functor_traits > { */ template struct scalar_product_op { enum { + // TODO vectorize mixed product Vectorizable = is_same::value && packet_traits::HasMul && packet_traits::HasMul }; typedef typename scalar_product_traits::ReturnType result_type; @@ -84,24 +85,27 @@ struct functor_traits > { * * This is a short cut for conj(x) * y which is needed for optimization purpose; in Eigen2 support mode, this becomes x * conj(y) */ -template struct scalar_conj_product_op { +template struct scalar_conj_product_op { enum { - Conj = NumTraits::IsComplex + Conj = NumTraits::IsComplex }; + typedef typename scalar_product_traits::ReturnType result_type; + EIGEN_EMPTY_STRUCT_CTOR(scalar_conj_product_op) - EIGEN_STRONG_INLINE const Scalar operator() (const Scalar& a, const Scalar& b) const - { return conj_helper().pmul(a,b); } + EIGEN_STRONG_INLINE const result_type operator() (const LhsScalar& a, const RhsScalar& b) const + { return conj_helper().pmul(a,b); } + template EIGEN_STRONG_INLINE const Packet packetOp(const Packet& a, const Packet& b) const { return conj_helper().pmul(a,b); } }; -template -struct functor_traits > { +template +struct functor_traits > { enum { - Cost = NumTraits::MulCost, - PacketAccess = packet_traits::HasMul + Cost = NumTraits::MulCost, + PacketAccess = internal::is_same::value && packet_traits::HasMul }; }; @@ -622,6 +626,7 @@ template struct functor_has_linear_access struct functor_allows_mixing_real_and_complex { enum { ret = 0 }; }; template struct functor_allows_mixing_real_and_complex > { enum { ret = 1 }; }; +template struct functor_allows_mixing_real_and_complex > { enum { ret = 1 }; }; /** \internal diff --git a/Eigen/src/Core/MatrixBase.h b/Eigen/src/Core/MatrixBase.h index 3b854ca5e..f318bfd5d 100644 --- a/Eigen/src/Core/MatrixBase.h +++ b/Eigen/src/Core/MatrixBase.h @@ -202,10 +202,11 @@ template class MatrixBase #if EIGEN2_SUPPORT_STAGE != STAGE20_RESOLVE_API_CONFLICTS template + typename internal::scalar_product_traits::Scalar,typename internal::traits::Scalar>::ReturnType #if EIGEN2_SUPPORT_STAGE == STAGE15_RESOLVE_API_CONFLICTS_WARN - EIGEN_DEPRECATED + EIGEN_DEPRECATED Scalar #endif - Scalar dot(const MatrixBase& other) const; + dot(const MatrixBase& other) const; #endif #ifdef EIGEN2_SUPPORT diff --git a/Eigen/src/Core/util/ForwardDeclarations.h b/Eigen/src/Core/util/ForwardDeclarations.h index 5a2de7095..a516a7094 100644 --- a/Eigen/src/Core/util/ForwardDeclarations.h +++ b/Eigen/src/Core/util/ForwardDeclarations.h @@ -155,7 +155,7 @@ template struct scalar_sum_op; template struct scalar_difference_op; -template struct scalar_conj_product_op; +template struct scalar_conj_product_op; template struct scalar_quotient_op; template struct scalar_opposite_op; template struct scalar_conjugate_op; diff --git a/test/adjoint.cpp b/test/adjoint.cpp index 72cbf3406..47889591f 100644 --- a/test/adjoint.cpp +++ b/test/adjoint.cpp @@ -106,6 +106,11 @@ template void adjoint(const MatrixType& m) m3.transposeInPlace(); VERIFY_IS_APPROX(m3,m1.conjugate()); + // check mixed dot product + typedef Matrix RealVectorType; + RealVectorType rv1 = RealVectorType::Random(rows); + VERIFY_IS_APPROX(v1.dot(rv1.template cast()), v1.dot(rv1)); + VERIFY_IS_APPROX(rv1.template cast().dot(v1), rv1.dot(v1)); } void test_adjoint()