GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-04-18 15:49:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the typing of the Tasks in ForkJoin.h

Browse Source
This commit is contained in:
William Kong 2025-04-09 17:21:36 +00:00 committed by Rasmus Munk Larsen
parent 2cd47d743e
commit 11fd34cc1c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Eigen/src/ThreadPool/ForkJoin.h
View File

@ -76,7 +76,7 @@ class ForkJoinScheduler {
}
// Synchronous variant of ParallelForAsync.
// WARNING: Making nested calls to `ParallelFor`, e.g., calling `ParallelFor` inside a task passed into another
// WARNING: Making nested calls to `ParallelFor`, e.g., calling `ParallelFor` inside a task passed into another
// `ParallelFor` call, may lead to deadlocks due to how task stealing is implemented.
template <typename DoFnType, typename ThreadPoolEnv>
static void ParallelFor(Index start, Index end, Index granularity, DoFnType&& do_func,
@ -92,6 +92,7 @@ class ForkJoinScheduler {
// Schedules `right_thunk`, runs `left_thunk`, and runs other tasks until `right_thunk` has finished.
template <typename LeftType, typename RightType, typename ThreadPoolEnv>
static void ForkJoin(LeftType&& left_thunk, RightType&& right_thunk, ThreadPoolTempl<ThreadPoolEnv>* thread_pool) {
typedef typename ThreadPoolTempl<ThreadPoolEnv>::Task Task;
std::atomic<bool> right_done(false);
auto execute_right = [&right_thunk, &right_done]() {
std::forward<RightType>(right_thunk)();
@ -99,7 +100,7 @@ class ForkJoinScheduler {
};
thread_pool->Schedule(execute_right);
std::forward<LeftType>(left_thunk)();
ThreadPool::Task task;
Task task;
while (!right_done.load(std::memory_order_acquire)) {
thread_pool->MaybeGetTask(&task);
if (task.f) task.f();