GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-06-04 18:54:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix bicgstab for complexes, and avoid a duplicate computation

Browse Source
This commit is contained in:
Gael Guennebaud 2013-07-02 08:14:10 +02:00
parent f8e325356a
commit 1caeb814f0
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Eigen/src/IterativeLinearSolvers/BiCGSTAB.h
View File

@ -74,7 +74,7 @@ bool bicgstab(const MatrixType& mat, const Rhs& rhs, Dest& x,
// The new residual vector became too orthogonal to the arbitrarily choosen direction r0 // The new residual vector became too orthogonal to the arbitrarily choosen direction r0
// Let's restart with a new r0: // Let's restart with a new r0:
r0 = r; r0 = r;
r0_sqnorm = rho = r0.dot(r); rho = r0_sqnorm = r.squaredNorm();
if(restarts++ == 0) if(restarts++ == 0)
i = 0; i = 0;
} }
@ -91,9 +91,11 @@ bool bicgstab(const MatrixType& mat, const Rhs& rhs, Dest& x,
z = precond.solve(s); z = precond.solve(s);
t.noalias() = mat * z; t.noalias() = mat * z;
w = t.squaredNorm(); RealScalar tmp = t.squaredNorm();
if(w>RealScalar(0)) if(tmp>RealScalar(0))
w = t.dot(s) / t.squaredNorm(); w = t.dot(s) / tmp;
else
w = Scalar(0);
x += alpha * y + w * z; x += alpha * y + w * z;
r = s - w * t; r = s - w * t;
++i; ++i;