GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-06-04 18:54:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix stable_norm_1 test.

Browse Source 
Test enters an infinite loop if size is 1x1 when choosing to select
unique indices for adding `inf` and `NaN` to the input. Here we
revert to non-unique indices, and split the `hypotNorm` check into
two cases: one where both `inf` and `NaN` are added, and one where
only `NaN` is added.
This commit is contained in:
Antonio Sanchez 2021-01-21 09:44:42 -08:00
parent 660c6b857c
commit 25d8498f8b
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/stable_norm.cpp
View File

@ -161,12 +161,8 @@ template<typename MatrixType> void stable_norm(const MatrixType& m)
// mix // mix
{ {
// Ensure unique indices otherwise inf may be overwritten by NaN. Index i2 = internal::random<Index>(0,rows-1);
Index i2, j2; Index j2 = internal::random<Index>(0,cols-1);
do {
i2 = internal::random<Index>(0,rows-1);
j2 = internal::random<Index>(0,cols-1);
} while (i2 == i && j2 == j);
v = vrand; v = vrand;
v(i,j) = -std::numeric_limits<RealScalar>::infinity(); v(i,j) = -std::numeric_limits<RealScalar>::infinity();
v(i2,j2) = std::numeric_limits<RealScalar>::quiet_NaN(); v(i2,j2) = std::numeric_limits<RealScalar>::quiet_NaN();
@ -174,8 +170,13 @@ template<typename MatrixType> void stable_norm(const MatrixType& m)
VERIFY(!(numext::isfinite)(v.norm())); VERIFY((numext::isnan)(v.norm())); VERIFY(!(numext::isfinite)(v.norm())); VERIFY((numext::isnan)(v.norm()));
VERIFY(!(numext::isfinite)(v.stableNorm())); VERIFY((numext::isnan)(v.stableNorm())); VERIFY(!(numext::isfinite)(v.stableNorm())); VERIFY((numext::isnan)(v.stableNorm()));
VERIFY(!(numext::isfinite)(v.blueNorm())); VERIFY((numext::isnan)(v.blueNorm())); VERIFY(!(numext::isfinite)(v.blueNorm())); VERIFY((numext::isnan)(v.blueNorm()));
// hypot propagates inf over NaN. if (i2 != i || j2 != j) {
VERIFY(!(numext::isfinite)(v.hypotNorm())); VERIFY((numext::isinf)(v.hypotNorm())); // hypot propagates inf over NaN.
VERIFY(!(numext::isfinite)(v.hypotNorm())); VERIFY((numext::isinf)(v.hypotNorm()));
} else {
// inf is overwritten by NaN, expect norm to be NaN.
VERIFY(!(numext::isfinite)(v.hypotNorm())); VERIFY((numext::isnan)(v.hypotNorm()));
}
} }
// stableNormalize[d] // stableNormalize[d]