GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-06-04 18:54:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed potential race condition in the non blocking thread pool

Browse Source
This commit is contained in:
Benoit Steiner 2016-05-12 11:45:48 -07:00
parent a071629fec
commit 2a54b70d45
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
unsupported/Eigen/CXX11/src/ThreadPool/NonBlockingThreadPool.h
View File

@ -58,7 +58,7 @@ class NonBlockingThreadPoolTempl : public Eigen::ThreadPoolInterface {
} }
~NonBlockingThreadPoolTempl() { ~NonBlockingThreadPoolTempl() {
done_.store(true, std::memory_order_relaxed); done_ = true;
// Now if all threads block without work, they will start exiting. // Now if all threads block without work, they will start exiting.
// But note that threads can continue to work arbitrary long, // But note that threads can continue to work arbitrary long,
// block, submit new work, unblock and otherwise live full life. // block, submit new work, unblock and otherwise live full life.

11
unsupported/test/cxx11_non_blocking_thread_pool.cpp
View File

@ -12,6 +12,16 @@
#include "main.h" #include "main.h"
#include "Eigen/CXX11/ThreadPool" #include "Eigen/CXX11/ThreadPool"
static void test_create_destroy_empty_pool()
{
// Just create and destroy the pool. This will wind up and tear down worker
// threads. Ensure there are no issues in that logic.
for (int i = 0; i < 16; ++i) {
NonBlockingThreadPool tp(i);
}
}
static void test_parallelism() static void test_parallelism()
{ {
// Test we never-ever fail to match available tasks with idle threads. // Test we never-ever fail to match available tasks with idle threads.
@ -87,5 +97,6 @@ static void test_parallelism()
void test_cxx11_non_blocking_thread_pool() void test_cxx11_non_blocking_thread_pool()
{ {
CALL_SUBTEST(test_create_destroy_empty_pool());
CALL_SUBTEST(test_parallelism()); CALL_SUBTEST(test_parallelism());
} }