From 2e39cc40a4bb3fa704651dd2b87364f5578b3a8b Mon Sep 17 00:00:00 2001 From: Rasmus Munk Larsen Date: Thu, 4 Feb 2016 12:56:14 -0800 Subject: [PATCH] Fix condition that made the unit test spam stdout with bogus error messages. --- test/qr_colpivoting.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/qr_colpivoting.cpp b/test/qr_colpivoting.cpp index c777d5f94..9c989823e 100644 --- a/test/qr_colpivoting.cpp +++ b/test/qr_colpivoting.cpp @@ -45,7 +45,7 @@ template void qr() RealScalar x = (std::abs)(r(i, i)); RealScalar y = (std::abs)(r(i + 1, i + 1)); if (x < threshold && y < threshold) continue; - if (test_isApproxOrLessThan(x, y)) { + if (!test_isApproxOrLessThan(y, x)) { for (Index j = 0; j < (std::min)(rows, cols); ++j) { std::cout << "i = " << j << ", |r_ii| = " << (std::abs)(r(j, j)) << std::endl; } @@ -94,7 +94,7 @@ template void qr_fixedsize() RealScalar x = (std::abs)(r(i, i)); RealScalar y = (std::abs)(r(i + 1, i + 1)); if (x < threshold && y < threshold) continue; - if (test_isApproxOrLessThan(x, y)) { + if (!test_isApproxOrLessThan(y, x)) { for (Index j = 0; j < (std::min)(int(Rows), int(Cols)); ++j) { std::cout << "i = " << j << ", |r_ii| = " << (std::abs)(r(j, j)) << std::endl; } @@ -138,7 +138,7 @@ template void qr_kahan_matrix() RealScalar x = (std::abs)(r(i, i)); RealScalar y = (std::abs)(r(i + 1, i + 1)); if (x < threshold && y < threshold) continue; - if (test_isApproxOrLessThan(x, y)) { + if (!test_isApproxOrLessThan(y, x)) { for (Index j = 0; j < (std::min)(rows, cols); ++j) { std::cout << "i = " << j << ", |r_ii| = " << (std::abs)(r(j, j)) << std::endl; }