From 32823caa629a4f440a8a4af2c4ffb9f751d711ab Mon Sep 17 00:00:00 2001 From: Hauke Heibel Date: Wed, 3 Mar 2010 07:52:19 +0100 Subject: [PATCH] Adapted the comment and removed it from the public dox. --- Eigen/src/Core/Product.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Eigen/src/Core/Product.h b/Eigen/src/Core/Product.h index 04f89e743..865387b11 100644 --- a/Eigen/src/Core/Product.h +++ b/Eigen/src/Core/Product.h @@ -419,9 +419,6 @@ template<> struct ei_gemv_selector /** \returns the matrix product of \c *this and \a other. * * \note If instead of the matrix product you want the coefficient-wise product, see Cwise::operator*(). - * \note In MSVC, this function will not be inlined since ei_matrix_storage is an - * unwindable object for dynamic matrices. Thus it does not help tagging - * this function with EIGEN_STRONG_INLINE. * * \sa lazyProduct(), operator*=(const MatrixBase&), Cwise::operator*() */ @@ -430,6 +427,10 @@ template inline const typename ProductReturnType::Type MatrixBase::operator*(const MatrixBase &other) const { + // A note regarding the function declaration: In MSVC, this function will sometimes + // not be inlined since ei_matrix_storage is an unwindable object for dynamic + // matrices and product types are holding a member to store the result. + // Thus it does not help tagging this function with EIGEN_STRONG_INLINE. enum { ProductIsValid = Derived::ColsAtCompileTime==Dynamic || OtherDerived::RowsAtCompileTime==Dynamic