GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-09-14 10:23:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix undefined behavior. When resizing a default-constructed SparseArray, we end up calling memcpy(ptr, 0, 0), which is technically UB and gets caught by static analysis.

Browse Source
This commit is contained in:
vanhoucke 2015-06-19 15:53:30 +00:00
parent 4cc0c961f3
commit 368ea23406
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Eigen/src/SparseCore/CompressedStorage.h
View File

@ -229,8 +229,10 @@ class CompressedStorage
internal::scoped_array<Scalar> newValues(size); internal::scoped_array<Scalar> newValues(size);
internal::scoped_array<StorageIndex> newIndices(size); internal::scoped_array<StorageIndex> newIndices(size);
Index copySize = (std::min)(size, m_size); Index copySize = (std::min)(size, m_size);
internal::smart_copy(m_values, m_values+copySize, newValues.ptr()); if (copySize>0) {
internal::smart_copy(m_indices, m_indices+copySize, newIndices.ptr()); internal::smart_copy(m_values, m_values+copySize, newValues.ptr());
internal::smart_copy(m_indices, m_indices+copySize, newIndices.ptr());
}
std::swap(m_values,newValues.ptr()); std::swap(m_values,newValues.ptr());
std::swap(m_indices,newIndices.ptr()); std::swap(m_indices,newIndices.ptr());
m_allocatedSize = size; m_allocatedSize = size;