GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-07-31 17:22:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix flaky packetmath_1 test.

Browse Source
This commit is contained in:
Antonio Sánchez 2022-08-02 17:42:45 +00:00 committed by Rasmus Munk Larsen
parent 7896c7dc6b
commit 39d22ef46b
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/packetmath.cpp
View File

@ -37,7 +37,7 @@ inline T REF_NMADD(const T& a, const T& b, const T& c) {
} }
template <typename T> template <typename T>
inline T REF_NMSUB(const T& a, const T& b, const T& c) { inline T REF_NMSUB(const T& a, const T& b, const T& c) {
return (-a * b) - c; return (-a * b) - c;
} }
template <typename T> template <typename T>
inline T REF_DIV(const T& a, const T& b) { inline T REF_DIV(const T& a, const T& b) {
@ -679,10 +679,21 @@ void packetmath() {
CHECK_CWISE1_IF(PacketTraits::HasSqrt, numext::sqrt, internal::psqrt); CHECK_CWISE1_IF(PacketTraits::HasSqrt, numext::sqrt, internal::psqrt);
CHECK_CWISE1_IF(PacketTraits::HasRsqrt, numext::rsqrt, internal::prsqrt); CHECK_CWISE1_IF(PacketTraits::HasRsqrt, numext::rsqrt, internal::prsqrt);
CHECK_CWISE3_IF(true, REF_MADD, internal::pmadd); CHECK_CWISE3_IF(true, REF_MADD, internal::pmadd);
if (!std::is_same<Scalar, bool>::value && NumTraits<Scalar>::IsSigned) {
CHECK_CWISE3_IF(true, REF_NMSUB, internal::pnmsub);
}
// For pmsub, pnmadd, the values can cancel each other to become near zero,
// which can lead to very flaky tests. Here we ensure the signs are such that
// they do not cancel.
for (int i = 0; i < PacketSize; ++i) {
data1[i] = numext::abs(internal::random<Scalar>());
data1[i + PacketSize] = numext::abs(internal::random<Scalar>());
data1[i + 2 * PacketSize] = -numext::abs(internal::random<Scalar>());
}
if (!std::is_same<Scalar, bool>::value && NumTraits<Scalar>::IsSigned) { if (!std::is_same<Scalar, bool>::value && NumTraits<Scalar>::IsSigned) {
CHECK_CWISE3_IF(true, REF_MSUB, internal::pmsub); CHECK_CWISE3_IF(true, REF_MSUB, internal::pmsub);
CHECK_CWISE3_IF(true, REF_NMADD, internal::pnmadd); CHECK_CWISE3_IF(true, REF_NMADD, internal::pnmadd);
CHECK_CWISE3_IF(true, REF_NMSUB, internal::pnmsub);
} }
} }