From 3e5b3a33fadc6611f2c577fab69c7520afbe5a1b Mon Sep 17 00:00:00 2001 From: Gael Guennebaud Date: Tue, 20 Jan 2009 10:37:39 +0000 Subject: [PATCH] quick bugfix in QR::isFullRank() (not 100% sure about the reference value for the comparison to 0) --- Eigen/src/QR/QR.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Eigen/src/QR/QR.h b/Eigen/src/QR/QR.h index 88914af3a..7712bfbf2 100644 --- a/Eigen/src/QR/QR.h +++ b/Eigen/src/QR/QR.h @@ -57,7 +57,7 @@ template class QR } /** \returns whether or not the matrix is of full rank */ - bool isFullRank() const { return ei_isMuchSmallerThan(m_hCoeffs.cwise().abs().minCoeff(), Scalar(1)); } + bool isFullRank() const { return !ei_isMuchSmallerThan(m_qr.diagonal().cwise().abs().minCoeff(), Scalar(1)); } /** \returns a read-only expression of the matrix R of the actual the QR decomposition */ const Part, UpperTriangular>