GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-14 20:56:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Initialize primitives to fix -Wuninitialized-const-reference.

Browse Source 
The `meta` test generates warnings with the latest version of clang due
to passing uninitialized variables as const reference arguments.
```
test/meta.cpp:102:45: error: variable 'f' is uninitialized when passed as a const reference argument here [-Werror,-Wuninitialized-const-reference]
    VERIFY(( check_is_convertible(a.dot(b), f) ));
```
We don't actually use the variables, but initializing them eliminates the
new warning.

Fixes #2067.
This commit is contained in:
Antonio Sanchez 2020-11-18 08:02:15 -08:00 committed by Antonio Sánchez
parent 3669498f5a
commit 41d5d5334b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/meta.cpp
View File

@ -34,7 +34,7 @@ EIGEN_DECLARE_TEST(meta)
VERIFY((!internal::is_same<float,double>::value)); VERIFY((!internal::is_same<float,double>::value));
VERIFY((!internal::is_same<float,float&>::value)); VERIFY((!internal::is_same<float,float&>::value));
VERIFY((!internal::is_same<float,const float&>::value)); VERIFY((!internal::is_same<float,const float&>::value));
VERIFY(( internal::is_same<float,internal::remove_all<const float&>::type >::value)); VERIFY(( internal::is_same<float,internal::remove_all<const float&>::type >::value));
VERIFY(( internal::is_same<float,internal::remove_all<const float*>::type >::value)); VERIFY(( internal::is_same<float,internal::remove_all<const float*>::type >::value));
VERIFY(( internal::is_same<float,internal::remove_all<const float*&>::type >::value)); VERIFY(( internal::is_same<float,internal::remove_all<const float*&>::type >::value));
@ -63,13 +63,13 @@ EIGEN_DECLARE_TEST(meta)
VERIFY(( internal::is_same< internal::add_const_on_value_type<const float* const>::type, const float* const>::value)); VERIFY(( internal::is_same< internal::add_const_on_value_type<const float* const>::type, const float* const>::value));
VERIFY(( internal::is_same< internal::add_const_on_value_type<float* const>::type, const float* const>::value)); VERIFY(( internal::is_same< internal::add_const_on_value_type<float* const>::type, const float* const>::value));
VERIFY(( internal::is_same<float,internal::remove_reference<float&>::type >::value)); VERIFY(( internal::is_same<float,internal::remove_reference<float&>::type >::value));
VERIFY(( internal::is_same<const float,internal::remove_reference<const float&>::type >::value)); VERIFY(( internal::is_same<const float,internal::remove_reference<const float&>::type >::value));
VERIFY(( internal::is_same<float,internal::remove_pointer<float*>::type >::value)); VERIFY(( internal::is_same<float,internal::remove_pointer<float*>::type >::value));
VERIFY(( internal::is_same<const float,internal::remove_pointer<const float*>::type >::value)); VERIFY(( internal::is_same<const float,internal::remove_pointer<const float*>::type >::value));
VERIFY(( internal::is_same<float,internal::remove_pointer<float* const >::type >::value)); VERIFY(( internal::is_same<float,internal::remove_pointer<float* const >::type >::value));
// is_convertible // is_convertible
STATIC_CHECK(( internal::is_convertible<float,double>::value )); STATIC_CHECK(( internal::is_convertible<float,double>::value ));
@ -96,7 +96,7 @@ EIGEN_DECLARE_TEST(meta)
STATIC_CHECK((!internal::is_convertible<Array33f,int>::value )); STATIC_CHECK((!internal::is_convertible<Array33f,int>::value ));
STATIC_CHECK((!internal::is_convertible<MatrixXf,float>::value )); STATIC_CHECK((!internal::is_convertible<MatrixXf,float>::value ));
{ {
float f; float f = 0.0f;
MatrixXf A, B; MatrixXf A, B;
VectorXf a, b; VectorXf a, b;
VERIFY(( check_is_convertible(a.dot(b), f) )); VERIFY(( check_is_convertible(a.dot(b), f) ));
@ -126,7 +126,7 @@ EIGEN_DECLARE_TEST(meta)
#endif #endif
{ {
int i; int i = 0;
VERIFY(( check_is_convertible(fix<3>(), i) )); VERIFY(( check_is_convertible(fix<3>(), i) ));
VERIFY((!check_is_convertible(i, fix<DynamicIndex>()) )); VERIFY((!check_is_convertible(i, fix<DynamicIndex>()) ));
} }
@ -136,7 +136,7 @@ EIGEN_DECLARE_TEST(meta)
VERIFY(( internal::has_ReturnType<ScalarBinaryOpTraits<int,int> >::value )); VERIFY(( internal::has_ReturnType<ScalarBinaryOpTraits<int,int> >::value ));
VERIFY(( !internal::has_ReturnType<MatrixXf>::value )); VERIFY(( !internal::has_ReturnType<MatrixXf>::value ));
VERIFY(( !internal::has_ReturnType<int>::value )); VERIFY(( !internal::has_ReturnType<int>::value ));
VERIFY(internal::meta_sqrt<1>::ret == 1); VERIFY(internal::meta_sqrt<1>::ret == 1);
#define VERIFY_META_SQRT(X) VERIFY(internal::meta_sqrt<X>::ret == int(std::sqrt(double(X)))) #define VERIFY_META_SQRT(X) VERIFY(internal::meta_sqrt<X>::ret == int(std::sqrt(double(X))))
VERIFY_META_SQRT(2); VERIFY_META_SQRT(2);