GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-13 12:19:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix array unit test: isApprox(log(0),log(0)) is false, and summing up signed float value might result in very small values and thus large numerical errors

Browse Source
This commit is contained in:
Gael Guennebaud 2013-02-23 22:58:14 +01:00
parent 274c24c262
commit 42af5870a4
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/array.cpp
View File

@ -6,7 +6,7 @@
// This Source Code Form is subject to the terms of the Mozilla // This Source Code Form is subject to the terms of the Mozilla
// Public License v. 2.0. If a copy of the MPL was not distributed // Public License v. 2.0. If a copy of the MPL was not distributed
// with this file, You can obtain one at http://mozilla.org/MPL/2.0/. // with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
#define EIGEN_DONT_VECTORIZE
#include "main.h" #include "main.h"
template<typename ArrayType> void array(const ArrayType& m) template<typename ArrayType> void array(const ArrayType& m)
@ -64,8 +64,11 @@ template<typename ArrayType> void array(const ArrayType& m)
VERIFY_IS_APPROX(m1, m3 / m2); VERIFY_IS_APPROX(m1, m3 / m2);
// reductions // reductions
VERIFY_IS_APPROX(m1.colwise().sum().sum(), m1.sum()); VERIFY_IS_APPROX(m1.abs().colwise().sum().sum(), m1.abs().sum());
VERIFY_IS_APPROX(m1.rowwise().sum().sum(), m1.sum()); VERIFY_IS_APPROX(m1.abs().rowwise().sum().sum(), m1.abs().sum());
using std::abs;
VERIFY_IS_MUCH_SMALLER_THAN(abs(m1.colwise().sum().sum() - m1.sum()), m1.abs().sum());
VERIFY_IS_MUCH_SMALLER_THAN(abs(m1.rowwise().sum().sum() - m1.sum()), m1.abs().sum());
if (!internal::isApprox(m1.sum(), (m1+m2).sum(), test_precision<Scalar>())) if (!internal::isApprox(m1.sum(), (m1+m2).sum(), test_precision<Scalar>()))
VERIFY_IS_NOT_APPROX(((m1+m2).rowwise().sum()).sum(), m1.sum()); VERIFY_IS_NOT_APPROX(((m1+m2).rowwise().sum()).sum(), m1.sum());
VERIFY_IS_APPROX(m1.colwise().sum(), m1.colwise().redux(internal::scalar_sum_op<Scalar>())); VERIFY_IS_APPROX(m1.colwise().sum(), m1.colwise().redux(internal::scalar_sum_op<Scalar>()));
@ -188,8 +191,7 @@ template<typename ArrayType> void array_real(const ArrayType& m)
if(!NumTraits<Scalar>::IsComplex) if(!NumTraits<Scalar>::IsComplex)
VERIFY_IS_APPROX(internal::real(m1), m1); VERIFY_IS_APPROX(internal::real(m1), m1);
//VERIFY_IS_APPROX(m1.abs().log(), std::log(std::abs(m1))); VERIFY((m1.abs().log() == log(abs(m1))).all());
VERIFY_IS_APPROX(m1.abs().log(), log(abs(m1)));
// VERIFY_IS_APPROX(m1.exp(), std::exp(m1)); // VERIFY_IS_APPROX(m1.exp(), std::exp(m1));
VERIFY_IS_APPROX(m1.exp() * m2.exp(), exp(m1+m2)); VERIFY_IS_APPROX(m1.exp() * m2.exp(), exp(m1+m2));