Reverse::coeff*(int) functions are for vector only

This commit is contained in:
Gael Guennebaud 2009-02-06 09:13:04 +00:00
parent 6fbca94803
commit 4dc4ab3abb
2 changed files with 10 additions and 7 deletions

View File

@ -92,8 +92,7 @@ template<typename MatrixType, int Direction> class Reverse
((Direction == Horizontal) || (Direction == BothDirections)) ? m_matrix.cols() - col - 1 : col); ((Direction == Horizontal) || (Direction == BothDirections)) ? m_matrix.cols() - col - 1 : col);
} }
/* could be removed */ /* TODO have to be updated for vector expression only */
/*
inline const Scalar coeff(int index) const inline const Scalar coeff(int index) const
{ {
switch ( Direction ) switch ( Direction )
@ -113,6 +112,7 @@ template<typename MatrixType, int Direction> class Reverse
} }
/* TODO have to be updated for vector expression only */
inline Scalar& coeffRef(int index) inline Scalar& coeffRef(int index)
{ {
switch ( Direction ) switch ( Direction )
@ -130,9 +130,8 @@ template<typename MatrixType, int Direction> class Reverse
break; break;
} }
} }
*/
/* the following is not ready yet */ // the following is not ready yet
/* /*
// TODO: We must reverse the packet reading and writing, which is currently not done here, I think // TODO: We must reverse the packet reading and writing, which is currently not done here, I think
template<int LoadMode> template<int LoadMode>
@ -150,6 +149,7 @@ template<typename MatrixType, int Direction> class Reverse
x); x);
} }
// TODO have to be updated for vector expression only
template<int LoadMode> template<int LoadMode>
inline const PacketScalar packet(int index) const inline const PacketScalar packet(int index) const
{ {
@ -168,10 +168,8 @@ template<typename MatrixType, int Direction> class Reverse
break; break;
} }
} }
*/
/* could be removed */ // TODO have to be updated for vector expression only
/*
template<int LoadMode> template<int LoadMode>
inline void writePacket(int index, const PacketScalar& x) inline void writePacket(int index, const PacketScalar& x)
{ {

View File

@ -185,4 +185,9 @@ void test_reverse()
CALL_SUBTEST( reverse(Matrix<float, 100, 100>()) ); CALL_SUBTEST( reverse(Matrix<float, 100, 100>()) );
CALL_SUBTEST( reverse(Matrix<long double,Dynamic,Dynamic>(10,10)) ); CALL_SUBTEST( reverse(Matrix<long double,Dynamic,Dynamic>(10,10)) );
} }
Vector4f x; x << 1, 2, 3, 4;
Vector4f y; y << 4, 3, 2, 1;
VERIFY(x.reverse()[1] == 3);
VERIFY(x.reverse() == y);
} }