GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-05-01 16:24:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove common "noncopyable" base class from evaluator_base to get a chance to get EBO (Empty Base Optimization)

Browse Source 
Note: we should probbaly get rid of this class and define a macro instead.
This commit is contained in:
Gael Guennebaud 2016-12-20 15:51:30 +01:00
parent 316673bbde
commit 5271474b15
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Eigen/src/Core/CoreEvaluators.h
View File

@ -106,7 +106,7 @@ struct evaluator<const T>
// ---------- base class for all evaluators ---------- // ---------- base class for all evaluators ----------
template<typename ExpressionType> template<typename ExpressionType>
struct evaluator_base : public noncopyable struct evaluator_base
{ {
// TODO that's not very nice to have to propagate all these traits. They are currently only needed to handle outer,inner indices. // TODO that's not very nice to have to propagate all these traits. They are currently only needed to handle outer,inner indices.
typedef traits<ExpressionType> ExpressionTraits; typedef traits<ExpressionType> ExpressionTraits;
@ -114,6 +114,14 @@ struct evaluator_base : public noncopyable
enum { enum {
Alignment = 0 Alignment = 0
}; };
// noncopyable:
// Don't make this class inherit noncopyable as this kills EBO (Empty Base Optimization)
// and make complex evaluator much larger than then should do.
EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE evaluator_base() {}
EIGEN_DEVICE_FUNC EIGEN_STRONG_INLINE ~evaluator_base() {}
private:
EIGEN_DEVICE_FUNC evaluator_base(const evaluator_base&);
EIGEN_DEVICE_FUNC const evaluator_base& operator=(const evaluator_base&);
}; };
// -------------------- Matrix and Array -------------------- // -------------------- Matrix and Array --------------------