diff --git a/Eigen/src/SVD/SVD.h b/Eigen/src/SVD/SVD.h index 76c1995b8..7379b72f4 100644 --- a/Eigen/src/SVD/SVD.h +++ b/Eigen/src/SVD/SVD.h @@ -464,7 +464,7 @@ struct ei_solve_retval, Rhs> { Matrix aux = dec().matrixU().adjoint() * rhs().col(j); - for (Index i = 0; i < dec().rows(); ++i) + for (Index i = 0; i < dec().singularValues().size(); ++i) { Scalar si = dec().singularValues().coeff(i); if(si == RealScalar(0)) @@ -472,6 +472,8 @@ struct ei_solve_retval, Rhs> else aux.coeffRef(i) /= si; } + aux.tail(aux.size() - dec().singularValues().size()).setZero(); + const Index minsize = std::min(dec().rows(),dec().cols()); dst.col(j).head(minsize) = aux.head(minsize); if(dec().cols()>dec().rows()) dst.col(j).tail(cols()-minsize).setZero(); diff --git a/test/svd.cpp b/test/svd.cpp index 8836563d3..3003c9dff 100644 --- a/test/svd.cpp +++ b/test/svd.cpp @@ -51,7 +51,7 @@ template void svd(const MatrixType& m) } - if (rows==cols) + if (rows>=cols) { if (ei_is_same_type::ret) {