GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-07-26 06:44:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix 1x1 selfadjoint matrix-vector product bug

Browse Source
This commit is contained in:
Charles Schlosser 2025-07-07 17:32:54 +00:00
parent ac1b29f823
commit 6854da2ea0
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Eigen/src/Core/products/SelfadjointMatrixVector.h
View File

@ -173,6 +173,11 @@ struct selfadjoint_product_impl<Lhs, LhsMode, false, Rhs, 0, true> {
eigen_assert(dest.rows() == a_lhs.rows() && dest.cols() == a_rhs.cols()); eigen_assert(dest.rows() == a_lhs.rows() && dest.cols() == a_rhs.cols());
if (a_lhs.rows() == 1) {
dest = (alpha * a_lhs.coeff(0, 0)) * a_rhs;
return;
}
add_const_on_value_type_t<ActualLhsType> lhs = LhsBlasTraits::extract(a_lhs); add_const_on_value_type_t<ActualLhsType> lhs = LhsBlasTraits::extract(a_lhs);
add_const_on_value_type_t<ActualRhsType> rhs = RhsBlasTraits::extract(a_rhs); add_const_on_value_type_t<ActualRhsType> rhs = RhsBlasTraits::extract(a_rhs);

4
test/product_selfadjoint.cpp
View File

@ -57,6 +57,10 @@ void product_selfadjoint(const MatrixType& m) {
v1.tail(rows - 1) * v2.head(cols - 1).adjoint() + v2.head(cols - 1) * v1.tail(rows - 1).adjoint(); v1.tail(rows - 1) * v2.head(cols - 1).adjoint() + v2.head(cols - 1) * v1.tail(rows - 1).adjoint();
VERIFY_IS_APPROX(m2, m3.template triangularView<Lower>().toDenseMatrix()); VERIFY_IS_APPROX(m2, m3.template triangularView<Lower>().toDenseMatrix());
} }
// matrix-vector
m2 = m1.template triangularView<Lower>();
VERIFY_IS_APPROX(m1 * m4, m2.template selfadjointView<Lower>() * m4);
} }
EIGEN_DECLARE_TEST(product_selfadjoint) { EIGEN_DECLARE_TEST(product_selfadjoint) {