GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-05-20 16:47:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix bad fuzzy comparison in 3x3 tridiagonalization

Browse Source
This commit is contained in:
Gael Guennebaud 2010-07-16 16:38:58 +02:00
parent 044424b0e2
commit 6ab9e8632f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Eigen/src/Eigenvalues/Tridiagonalization.h
View File

@ -458,7 +458,7 @@ struct ei_tridiagonalization_inplace_selector
}; };
/** \internal /** \internal
* Specialization for 3x3 matrices. * Specialization for 3x3 real matrices.
* Especially useful for plane fitting. * Especially useful for plane fitting.
*/ */
template<typename MatrixType> template<typename MatrixType>
@ -472,7 +472,7 @@ struct ei_tridiagonalization_inplace_selector<MatrixType,3>
{ {
diag[0] = ei_real(mat(0,0)); diag[0] = ei_real(mat(0,0));
RealScalar v1norm2 = ei_abs2(mat(2,0)); RealScalar v1norm2 = ei_abs2(mat(2,0));
if (ei_isMuchSmallerThan(v1norm2, RealScalar(1))) if(v1norm2 == RealScalar(0) && ei_imag(mat(1,0))==RealScalar(0))
{ {
diag[1] = ei_real(mat(1,1)); diag[1] = ei_real(mat(1,1));
diag[2] = ei_real(mat(2,2)); diag[2] = ei_real(mat(2,2));
@ -495,8 +495,8 @@ struct ei_tridiagonalization_inplace_selector<MatrixType,3>
if (extractQ) if (extractQ)
{ {
mat << 1, 0, 0, mat << 1, 0, 0,
0, m01, m02, 0, m01, m02,
0, m02, -m01; 0, m02, -m01;
} }
} }
} }