GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-09-15 19:03:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add regression for bugs #1573 and #1575

Browse Source
This commit is contained in:
Gael Guennebaud 2018-07-18 23:34:34 +02:00
parent 863580fe88
commit 6e5a3b898f
1 changed files with 26 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
test/geo_quaternion.cpp
View File

@ -12,6 +12,7 @@
#include <Eigen/Geometry> #include <Eigen/Geometry>
#include <Eigen/LU> #include <Eigen/LU>
#include <Eigen/SVD> #include <Eigen/SVD>
#include "AnnoyingScalar.h"
template<typename T> T bounded_acos(T v) template<typename T> T bounded_acos(T v)
{ {
@ -85,7 +86,7 @@ template<typename Scalar, int Options> void quaternion(void)
if (refangle>Scalar(EIGEN_PI)) if (refangle>Scalar(EIGEN_PI))
refangle = Scalar(2)*Scalar(EIGEN_PI) - refangle; refangle = Scalar(2)*Scalar(EIGEN_PI) - refangle;
if((q1.coeffs()-q2.coeffs()).norm() > 10*largeEps) if((q1.coeffs()-q2.coeffs()).norm() > Scalar(10)*largeEps)
{ {
VERIFY_IS_MUCH_SMALLER_THAN(abs(q1.angularDistance(q2) - refangle), Scalar(1)); VERIFY_IS_MUCH_SMALLER_THAN(abs(q1.angularDistance(q2) - refangle), Scalar(1));
} }
@ -113,7 +114,7 @@ template<typename Scalar, int Options> void quaternion(void)
// Do not execute the test if the rotation angle is almost zero, or // Do not execute the test if the rotation angle is almost zero, or
// the rotation axis and v1 are almost parallel. // the rotation axis and v1 are almost parallel.
if (abs(aa.angle()) > 5*test_precision<Scalar>() if (abs(aa.angle()) > Scalar(5)*test_precision<Scalar>()
&& (aa.axis() - v1.normalized()).norm() < Scalar(1.99) && (aa.axis() - v1.normalized()).norm() < Scalar(1.99)
&& (aa.axis() + v1.normalized()).norm() < Scalar(1.99)) && (aa.axis() + v1.normalized()).norm() < Scalar(1.99))
{ {
@ -285,18 +286,36 @@ template<typename PlainObjectType> void check_const_correctness(const PlainObjec
VERIFY( !(Map<ConstPlainObjectType, Aligned>::Flags & LvalueBit) ); VERIFY( !(Map<ConstPlainObjectType, Aligned>::Flags & LvalueBit) );
} }
#if EIGEN_HAS_RVALUE_REFERENCES
// Regression for bug 1573
struct MovableClass {
MovableClass() = default;
MovableClass(const MovableClass&) = default;
MovableClass(MovableClass&&) noexcept = default;
MovableClass& operator=(const MovableClass&) = default;
MovableClass& operator=(MovableClass&&) = default;
Quaternionf m_quat;
};
#endif
EIGEN_DECLARE_TEST(geo_quaternion) EIGEN_DECLARE_TEST(geo_quaternion)
{ {
for(int i = 0; i < g_repeat; i++) { for(int i = 0; i < g_repeat; i++) {
CALL_SUBTEST_1(( quaternion<float,AutoAlign>() )); CALL_SUBTEST_1(( quaternion<float,AutoAlign>() ));
CALL_SUBTEST_1( check_const_correctness(Quaternionf()) ); CALL_SUBTEST_1( check_const_correctness(Quaternionf()) );
CALL_SUBTEST_1(( quaternion<float,DontAlign>() ));
CALL_SUBTEST_1(( quaternionAlignment<float>() ));
CALL_SUBTEST_1( mapQuaternion<float>() );
CALL_SUBTEST_2(( quaternion<double,AutoAlign>() )); CALL_SUBTEST_2(( quaternion<double,AutoAlign>() ));
CALL_SUBTEST_2( check_const_correctness(Quaterniond()) ); CALL_SUBTEST_2( check_const_correctness(Quaterniond()) );
CALL_SUBTEST_3(( quaternion<float,DontAlign>() )); CALL_SUBTEST_2(( quaternion<double,DontAlign>() ));
CALL_SUBTEST_4(( quaternion<double,DontAlign>() )); CALL_SUBTEST_2(( quaternionAlignment<double>() ));
CALL_SUBTEST_5(( quaternionAlignment<float>() ));
CALL_SUBTEST_6(( quaternionAlignment<double>() ));
CALL_SUBTEST_1( mapQuaternion<float>() );
CALL_SUBTEST_2( mapQuaternion<double>() ); CALL_SUBTEST_2( mapQuaternion<double>() );
AnnoyingScalar::dont_throw = true;
CALL_SUBTEST_3(( quaternion<AnnoyingScalar,AutoAlign>() ));
} }
} }