GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-07-22 04:44:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix a super nasty bug: on row-major expressions that are NOT vectors but that

Browse Source 
do have LinearAccess, the MapBase::coeff(int) and MapBase::coeffRef(int)
methods were broken.
This commit is contained in:
Benoit Jacob 2010-01-21 23:33:20 -05:00
parent c2b8ca7493
commit 72044ca925
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Eigen/src/Core/MapBase.h
View File

@ -99,7 +99,7 @@ template<typename Derived> class MapBase
inline const Scalar coeff(int index) const inline const Scalar coeff(int index) const
{ {
ei_assert(Derived::IsVectorAtCompileTime || (ei_traits<Derived>::Flags & LinearAccessBit)); ei_assert(Derived::IsVectorAtCompileTime || (ei_traits<Derived>::Flags & LinearAccessBit));
if ( ((RowsAtCompileTime == 1) == IsRowMajor) ) if ( ((RowsAtCompileTime == 1) == IsRowMajor) || !int(Derived::IsVectorAtCompileTime) )
return m_data[index]; return m_data[index];
else else
return m_data[index*stride()]; return m_data[index*stride()];
@ -108,7 +108,7 @@ template<typename Derived> class MapBase
inline Scalar& coeffRef(int index) inline Scalar& coeffRef(int index)
{ {
ei_assert(Derived::IsVectorAtCompileTime || (ei_traits<Derived>::Flags & LinearAccessBit)); ei_assert(Derived::IsVectorAtCompileTime || (ei_traits<Derived>::Flags & LinearAccessBit));
if ( ((RowsAtCompileTime == 1) == IsRowMajor) ) if ( ((RowsAtCompileTime == 1) == IsRowMajor) || !int(Derived::IsVectorAtCompileTime) )
return const_cast<Scalar*>(m_data)[index]; return const_cast<Scalar*>(m_data)[index];
else else
return const_cast<Scalar*>(m_data)[index*stride()]; return const_cast<Scalar*>(m_data)[index*stride()];