GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-12 11:49:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix spasre triangular solve for row major lower matrices

Browse Source
This commit is contained in:
Gael Guennebaud 2009-12-14 10:25:21 +01:00
parent 9facdaf7b9
commit 7a9988ebb6
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Eigen/src/Sparse/TriangularSolver.h
View File

@ -52,6 +52,8 @@ struct ei_sparse_solve_triangular_selector<Lhs,Rhs,Mode,LowerTriangular,RowMajor
{ {
lastVal = it.value(); lastVal = it.value();
lastIndex = it.index(); lastIndex = it.index();
if(lastIndex==i)
break;
tmp -= lastVal * other.coeff(lastIndex,col); tmp -= lastVal * other.coeff(lastIndex,col);
} }
if (Mode & UnitDiagBit) if (Mode & UnitDiagBit)

10
test/sparse_solvers.cpp
View File

@ -73,7 +73,15 @@ template<typename Scalar> void sparse_solvers(int rows, int cols)
VERIFY_IS_APPROX(refMat2.template triangularView<UpperTriangular>().solve(vec2), VERIFY_IS_APPROX(refMat2.template triangularView<UpperTriangular>().solve(vec2),
m2.template triangularView<UpperTriangular>().solve(vec3)); m2.template triangularView<UpperTriangular>().solve(vec3));
// TODO test row major // lower - transpose
initSparse<Scalar>(density, refMat2, m2, ForceNonZeroDiag|MakeLowerTriangular, &zeroCoords, &nonzeroCoords);
VERIFY_IS_APPROX(refMat2.template marked<LowerTriangular>().transpose().solveTriangular(vec2),
m2.template marked<LowerTriangular>().transpose().solveTriangular(vec3));
// upper - transpose
initSparse<Scalar>(density, refMat2, m2, ForceNonZeroDiag|MakeUpperTriangular, &zeroCoords, &nonzeroCoords);
VERIFY_IS_APPROX(refMat2.template marked<UpperTriangular>().transpose().solveTriangular(vec2),
m2.template marked<UpperTriangular>().transpose().solveTriangular(vec3));
SparseMatrix<Scalar> matB(rows, rows); SparseMatrix<Scalar> matB(rows, rows);
DenseMatrix refMatB = DenseMatrix::Zero(rows, rows); DenseMatrix refMatB = DenseMatrix::Zero(rows, rows);