GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-13 20:26:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use padding instead of alignment attribute, which MaxSizeVector does not respect. This leads to undefined behavior and hard-to-trace bugs.

Browse Source
This commit is contained in:
Rasmus Munk Larsen 2018-09-05 11:20:06 -07:00
parent 5927eef612
commit 8b3d9ed081
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
unsupported/Eigen/CXX11/src/ThreadPool/EventCount.h
View File

@ -169,9 +169,7 @@ class EventCount {
class Waiter { class Waiter {
friend class EventCount; friend class EventCount;
// Align to 128 byte boundary to prevent false sharing with other Waiter std::atomic<Waiter*> next;
// objects in the same vector.
EIGEN_ALIGN_TO_BOUNDARY(128) std::atomic<Waiter*> next;
std::mutex mu; std::mutex mu;
std::condition_variable cv; std::condition_variable cv;
uint64_t epoch; uint64_t epoch;
@ -181,6 +179,9 @@ class EventCount {
kWaiting, kWaiting,
kSignaled, kSignaled,
}; };
// Pad past 128 byte boundary to prevent false sharing with other Waiter
// objects in the same vector.
char pad_[128];
}; };
private: private: