GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-12 03:39:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix #66 : upper triangular checks in ComplexSchur

Browse Source
This commit is contained in:
Gael Guennebaud 2009-11-02 10:46:40 +01:00
parent 5ba19a53a6
commit 979431b987
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Eigen/Eigenvalues
View File

@ -8,6 +8,7 @@
#include "Cholesky" #include "Cholesky"
#include "Jacobi" #include "Jacobi"
#include "Householder" #include "Householder"
#include "LU"
// Note that EIGEN_HIDE_HEAVY_CODE has to be defined per module // Note that EIGEN_HIDE_HEAVY_CODE has to be defined per module
#if (defined EIGEN_EXTERN_INSTANTIATIONS) && (EIGEN_EXTERN_INSTANTIATIONS>=2) #if (defined EIGEN_EXTERN_INSTANTIATIONS) && (EIGEN_EXTERN_INSTANTIATIONS>=2)

16
Eigen/src/Eigenvalues/ComplexSchur.h
View File

@ -167,10 +167,11 @@ void ComplexSchur<MatrixType>::compute(const MatrixType& matrix, bool skipU)
//locate the range in which to iterate //locate the range in which to iterate
while(iu > 0) while(iu > 0)
{ {
d = ei_norm1(m_matT.coeffRef(iu,iu)) + ei_norm1(m_matT.coeffRef(iu-1,iu-1)); d = ei_norm1(m_matT.coeff(iu,iu)) + ei_norm1(m_matT.coeff(iu-1,iu-1));
sd = ei_norm1(m_matT.coeffRef(iu,iu-1)); sd = ei_norm1(m_matT.coeff(iu,iu-1));
if(sd >= eps * d) break; // FIXME : precision criterion ?? if(!ei_isMuchSmallerThan(sd,d,eps))
break;
m_matT.coeffRef(iu,iu-1) = Complex(0); m_matT.coeffRef(iu,iu-1) = Complex(0);
iter = 0; iter = 0;
@ -187,13 +188,14 @@ void ComplexSchur<MatrixType>::compute(const MatrixType& matrix, bool skipU)
} }
il = iu-1; il = iu-1;
while( il > 0 ) while(il > 0)
{ {
// check if the current 2x2 block on the diagonal is upper triangular // check if the current 2x2 block on the diagonal is upper triangular
d = ei_norm1(m_matT.coeffRef(il,il)) + ei_norm1(m_matT.coeffRef(il-1,il-1)); d = ei_norm1(m_matT.coeff(il,il)) + ei_norm1(m_matT.coeff(il-1,il-1));
sd = ei_norm1(m_matT.coeffRef(il,il-1)); sd = ei_norm1(m_matT.coeff(il,il-1));
if(sd < eps * d) break; // FIXME : precision criterion ?? if(ei_isMuchSmallerThan(sd,d,eps))
break;
--il; --il;
} }