GitHub-Proxy/eigen
1
0
Fork 0
mirror of https://gitlab.com/libeigen/eigen.git synced 2025-08-11 11:19:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

bugfix in SVD

Browse Source
This commit is contained in:
Gael Guennebaud 2009-07-20 13:44:52 +02:00
parent 4375c043ac
commit a012aecbc4
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Eigen/src/SVD/SVD.h
View File

@ -125,7 +125,7 @@ template<typename MatrixType> class SVD
{ {
return (b >= Scalar(0.0) ? ei_abs(a) : -ei_abs(a)); return (b >= Scalar(0.0) ? ei_abs(a) : -ei_abs(a));
} }
protected: protected:
/** \internal */ /** \internal */
MatrixUType m_matU; MatrixUType m_matU;
@ -254,11 +254,14 @@ void SVD<MatrixType>::compute(const MatrixType& matrix)
if (g != Scalar(0.0)) if (g != Scalar(0.0))
{ {
g = Scalar(1.0)/g; g = Scalar(1.0)/g;
for (j=l; j<n; j++) if (m-l)
{ {
s = A.col(i).end(m-l).dot(A.col(j).end(m-l)); for (j=l; j<n; j++)
f = (s/A(i,i))*g; {
A.col(j).end(m-i) += f * A.col(i).end(m-i); s = A.col(i).end(m-l).dot(A.col(j).end(m-l));
f = (s/A(i,i))*g;
A.col(j).end(m-i) += f * A.col(i).end(m-i);
}
} }
A.col(i).end(m-i) *= g; A.col(i).end(m-i) *= g;
} }