Speed up SparseQR.

This commit is contained in:
Rasmus Munk Larsen 2024-02-22 16:49:10 -08:00
parent feaafda30a
commit a6dc930d16

View File

@ -481,9 +481,7 @@ void SparseQR<MatrixType, OrderingType>::factorize(const MatrixType& mat) {
tdot *= m_hcoeffs(curIdx);
// Then update tval = tval - q * tau
// FIXME: tval -= tdot * m_Q.col(curIdx) should amount to the same (need to check/add support for efficient "dense
// ?= sparse")
for (typename QRMatrixType::InnerIterator itq(m_Q, curIdx); itq; ++itq) tval(itq.row()) -= itq.value() * tdot;
tval -= tdot * m_Q.col(curIdx);
// Detect fill-in for the current column of Q
if (m_etree(Ridx(i)) == nonzeroCol) {